[Bug 16064] New: Remove use of image to indicate approval in tags moderation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Bug ID: 16064 Summary: Remove use of image to indicate approval in tags moderation Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tags/review.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 16062 I would like to be able to eliminate use of "approve.gif" as part of Bug 16062, so I propose to take it out of the tags moderation template and use text instead. This has the added benefit of being more consistent and accessible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 [Bug 16062] Remove CSS and images related to old "approve" and "deny" button styles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49097&action=edit Bug 16064 - Remove use of image to indicate approval in tags moderation This patch updates the tags moderation template to use text labels to mark tag moderation status, eliminating the use of an image file to signify approval. To test you should have some tags in each approval state: pending, approved, and rejected. - Apply the patch and go to Tools -> Tags. - Confirm that the status of each tag is clearly shown with a text label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49097|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49127&action=edit Bug 16064 - Remove use of image to indicate approval in tags moderation This patch updates the tags moderation template to use text labels to mark tag moderation status, eliminating the use of an image file to signify approval. To test you should have some tags in each approval state: pending, approved, and rejected. - Apply the patch and go to Tools -> Tags. - Confirm that the status of each tag is clearly shown with a text label. Works as expected (Do not forget to set filter at the left to 'all' for testing) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49127|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49215&action=edit Bug 16064 - Remove use of image to indicate approval in tags moderation This patch updates the tags moderation template to use text labels to mark tag moderation status, eliminating the use of an image file to signify approval. To test you should have some tags in each approval state: pending, approved, and rejected. - Apply the patch and go to Tools -> Tags. - Confirm that the status of each tag is clearly shown with a text label. Works as expected (Do not forget to set filter at the left to 'all' for testing) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org