[Bug 39721] New: Remove GetSuggestion from C4/Suggestions.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Bug ID: 39721 Summary: Remove GetSuggestion from C4/Suggestions.pm Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181402&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm This set of patches removes the major part of C4/Suggestions. They have been split for sake of QA's readability but should be squashed. Things to test: Create suggestion Update status of suggestion Create, see and receive an order containing a suggestion Create a suggestion on an already existing record (it will need validation) test cronjobs purge_suggestion and notice_unprocessed_suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39722 [Bug 39722] Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181402|0 |1 is obsolete| | --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181416&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181416|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182810&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |jonathan.druart@gmail.com Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I would not call unblessed but manipulate the object directly here. It's a bit more work here but it will be easier for the other changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- ping? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182810|0 |1 is obsolete| | --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185280&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185281&action=edit Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by :
25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script.
In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185282&action=edit Bug 39721: (follow-up) Remove unblessed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185283&action=edit Bug 39721: tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife@openfifth.co | |.uk --- Comment #10 from Bernard <bernard.scaife@openfifth.co.uk> --- Hi Baptiste, When I install your patch, I am unable to create or modify a suggestion in the staff intranet and get a 500 error. The log shows: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'CAD' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 401 Looks like that is a reference to Canadian Dollars currency (CAD) It still works fine to create a request in the OPAC. Hope this helps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- There is also: qw( suggestedbyme op displayby tabcode notify filter_archived koha_login_context auth_forwarded_hash password userid ); [2025/09/02 12:49:03] [WARN] Useless use of a constant ("suggestedbyme") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("op") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("displayby") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("tabcode") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("notify") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("filter_archived") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("koha_login_context") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("auth_forwarded_hash") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("password") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102. [2025/09/02 12:49:03] [WARN] Useless use of a constant ("userid") in void context at /kohadevbox/koha/suggestion/suggestion.pl line 102 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- I would restart from scratch here. You should not try to remove suggestion_ref. suggestion.pl is used for add/edit but also for searching. On this specific bug you should focus on GetSuggestion only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #12)
I would restart from scratch here. You should not try to remove suggestion_ref.
suggestion.pl is used for add/edit but also for searching.
Sorry, this is wrong since we now have bug 33430. Keep trying this way then! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- comment 10 is because you removed this line: - map { delete $$suggestion_ref{$_} unless $_ eq 'branchcode' } keys %$suggestion_ref; There are other lines that have been removed incorrectly IMO: -foreach my $key ( keys %$suggestion_ref ) { - delete $suggestion_ref->{$key} if ( !$suggestion_ref->{$key} && ( $op eq 'else' ) ); - delete $suggestion_ref->{$key} if $key =~ m{^DataTables_acqui_suggestions_suggestions}; -} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 188646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188646&action=edit Bug 39721: fix suggestion_ref issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185280|0 |1 is obsolete| | --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 188648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188648&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185281|0 |1 is obsolete| | --- Comment #17 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 188649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188649&action=edit Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by :
25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script.
In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185282|0 |1 is obsolete| | --- Comment #18 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 188650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188650&action=edit Bug 39721: (follow-up) Remove unblessed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185283|0 |1 is obsolete| | --- Comment #19 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 188651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188651&action=edit Bug 39721: tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188646|0 |1 is obsolete| | --- Comment #20 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 188652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188652&action=edit Bug 39721: fix suggestion_ref issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188648|0 |1 is obsolete| | --- Comment #21 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190940&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188649|0 |1 is obsolete| | --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190941&action=edit Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by :
25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script.
In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |matt.blenkinsop@openfifth.c | |o.uk --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Applying: Bug 39721: (follow-up) Remove unblessed error: sha1 information is lacking or useless (t/db_dependent/Suggestions.t). error: could not build fake ancestor Patch failed at 0001 Bug 39721: (follow-up) Remove unblessed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188652|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #24 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Sry I did not obsolete the patches after squashing, I just re-tested it should be fine now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190940|0 |1 is obsolete| | --- Comment #25 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 191656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191656&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190941|0 |1 is obsolete| | --- Comment #26 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 191657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191657&action=edit Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by :
25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script.
In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191656|0 |1 is obsolete| | --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191909&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191657|0 |1 is obsolete| | --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191910&action=edit Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by :
25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script.
In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #29 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Yep @joubu there are still 2 unblessed The first one is in ModSuggestion which will not survive this cycle of patches. The second is in acqui/neworderempty.pl, but it is stored in a variable called $data, which is either an hashref from GetSuggestion or an hashref from GetBiblioData. Do you think we can remove this unblessed ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Please add test coverage for Koha::Suggestion::accepter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #29)
The second is in acqui/neworderempty.pl, but it is stored in a variable called $data, which is either an hashref from GetSuggestion or an hashref from GetBiblioData. Do you think we can remove this unblessed ?
I think it's ok for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #32 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 191927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191927&action=edit Bug 39721: Add test for accepter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41695 [Bug 41695] Suggestion->refuser returns the manager -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191927|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192020&action=edit Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Amended-by: Jonathan Druart tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192021&action=edit Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by :
25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script.
In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192022&action=edit Bug 39721: Add test for accepter Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 [Bug 41857] Suggestions table actions broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41997 [Bug 41997] Default suggester is not passed by the suggestion creation form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41998 [Bug 41998] Some templates in suggester.pl are computed even through a redirection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 --- Comment #37 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #38 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42710 [Bug 42710] Purchase suggestion creation form (staff interface) no longer defaults to logged-in library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #39 from David Nind <david@davidnind.com> --- Technical change, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 [Bug 42723] Purchase suggestion 500 when EmailPurchaseSuggestions is set to BranchEmailAddress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42740 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42740 [Bug 42740] Suggestion status is not kept when editing a suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42750 [Bug 42750] Purchase suggestions made from members/purchase-suggestions.pl no longer redirect back -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42723 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 [Bug 42723] Purchase suggestion 500 page error when EmailPurchaseSuggestions is set to "email address of library" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 [Bug 42757] Suggester is not passed by purchase-suggestions.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42757 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 [Bug 42757] Suggester is not passed by purchase-suggestions.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 [Bug 42919] Suggestion duplicate warning erases suggestion info -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org