https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- I put wrong example. Actually, the problem arises only with thesauri defined in with 008/11 = 'z' and 040 $f. Example: biblio: 650 _7 $a Filozofia $2 dbn [thesaurus: dbn] will be linked to an authority 008/11 = z 040 $f kaba 150 __ $a Filozofia if authority record: 008/11 = z 040 $f dbn 150 __ $a Filozofia is missing in the system. This is obviously wrong--we should not link to a authority record belonging to a different thesaurus. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- This happens when thesaurus in bibliographic field 6XX is defined by subfield $2. In such a case the authority record should have 008/11 = 'z' and, according to https://www.loc.gov/marc/authority/ad008.html (cf. comment for 008/11 = 'z': "A MARC code for the conventions used to formulate the heading *may* be contained in subfield $f"), may or may have thesaurus declared in 040 $f. This is why we make a second search attempt in C4::Heading::_search, but doing so we have to make sure that the resulting authority record has not a different thesaurus declared in 040 $f. (Note that 008/11 and 040 $f are indexed with the same search field: subject-heading-thesaurus. So we search for the second time in the same search field but with 'notdefined' == 008/11='z' instead of the original thesaurus taken from subfield $2 of the bibliographic field 6XX.) This means we have to explicitly check the content of 040 $f of the resulting authority record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 --- Comment #3 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 180082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180082&action=edit Bug 39503: Bug 39503 - Linker should always respect thesaurus with LinkerConsiderThesaurus on With bug 30280 and subsequent patches we attempt to respect the thesaurus indication when linking with LinkerConsiderThesaurus on. However, there are still cases when we link wrong. This happens when thesaurus in bibliographic field 6XX is defined by subfield $2. In such a case the authority record should have 008/11 = 'z' and, according to https://www.loc.gov/marc/authority/ad008.html (cf. comment for 008/11 = 'z': "A MARC code for the conventions used to formulate the heading *may* be contained in subfield $f"), may or may have thesaurus declared in 040 $f. This is why we make a second search attempt in C4::Heading::_search, but doing so we have to make sure that the resulting authority record has not a different thesaurus declared in 040 $f. (Note that 008/11 and 040 $f are indexed with the same search field: subject-heading-thesaurus. So we search for the second time in the same search field but with 'notdefined' == 008/11='z' instead of the original thesaurus taken from subfield $2 of the bibliographic field 6XX.) This means we have to explicitly check the content of 040 $f of the resulting authority record. Test plan: ========== 1. Turn on the LinkerConsiderThesaurus systempreference. 2. Create an authority record (e.g. TOPIC_TERM) with 008/11 = 'z' and 040 $f containing a thesaurus indication (e.g. 'kaba'), and a term in field 150 $a (e.g. Early music). 3. Edit a bibliographic record: in field 650 put 2nd indicator '7', the term 'Early music' in $a, and a different thesaurus code in $2 (e.g. 'dbn'). Click the 'Link authorities automatically' button. Note that 650 'Early music' (dbn) has been linked with and authority record 'Early music' (kaba). This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 3. Now the 650 'Early music' (dbn) has not been linked to an authority record (650 - No matching authority found.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 180201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180201&action=edit Bug 39503: Unit tests NB, some previous test had to be adjusted to make it posible to call search_auth_compat in _search and properly interpret its results. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180200|0 |1 is obsolete| | Attachment #180201|0 |1 is obsolete| | Attachment #180844|0 |1 is obsolete| | --- Comment #8 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 180902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180902&action=edit Bug 39503: Collapse thesaurus if value in 008/_11 and 040 With bug 30280 and subsequent patches we attempt to respect the thesaurus indication when linking with LinkerConsiderThesaurus on. However, there are still cases when we link wrong. This happens when thesaurus in bibliographic field 6XX is defined by subfield $2. In such a case the authority record should have 008/11 = 'z' and, according to https://www.loc.gov/marc/authority/ad008.html (cf. comment for 008/11 = 'z': "A MARC code for the conventions used to formulate the heading *may* be contained in subfield $f"), may or may have thesaurus declared in 040 $f. This is why we make a second search attempt in C4::Heading::_search, but doing so we have to make sure that the resulting authority record has not a different thesaurus declared in 040 $f. (Note that 008/11 and 040 $f are indexed with the same search field: subject-heading-thesaurus. So we search for the second time in the same search field but with 'notdefined' == 008/11='z' instead of the original thesaurus taken from subfield $2 of the bibliographic field 6XX.) This means we have to explicitly check the content of 040 $f of the resulting authority record. Test plan: ========== 1. Turn on the LinkerConsiderThesaurus systempreference. 2. Create an authority record (e.g. TOPIC_TERM) with 008/11 = 'z' and 040 $f containing a thesaurus indication (e.g. 'kaba'), and a term in field 150 $a (e.g. Early music). 3. Edit a bibliographic record: in field 650 put 2nd indicator '7', the term 'Early music' in $a, and a different thesaurus code in $2 (e.g. 'dbn'). Click the 'Link authorities automatically' button. Note that 650 'Early music' (dbn) has been linked with and authority record 'Early music' (kaba). This is wrong. 4. Apply the patch ; restart_all ; reindex ES for authorities with: koha-elasticsearch --rebuild -d -a kohadev 5. Repeat p. 3. Now the 650 'Early music' (dbn) has not been linked to an authority record (650 - No matching authority found.) Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 --- Comment #11 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 180941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180941&action=edit Bug 39503: Unit tests NB, some previous test had to be adjusted to make it posible to call search_auth_compat in _search and properly interpret its results. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180940|0 |1 is obsolete| | --- Comment #12 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181205&action=edit Bug 39503: Collapse thesaurus if value in 008_/11 = 'z' and 040 $f With bug 30280 and subsequent patches we attempt to respect the thesaurus indication when linking with LinkerConsiderThesaurus on. However, there are still cases when we link wrong. This happens when thesaurus in bibliographic field 6XX is defined by subfield $2. In such a case the authority record should have 008/11 = 'z' and, according to https://www.loc.gov/marc/authority/ad008.html (cf. comment for 008/11 = 'z': "A MARC code for the conventions used to formulate the heading *may* be contained in subfield $f"), may or may have thesaurus declared in 040 $f. This is why we make a second search attempt in C4::Heading::_search, but doing so we have to make sure that the resulting authority record has not a different thesaurus declared in 040 $f. (Note that 008/11 and 040 $f are indexed with the same search field: subject-heading-thesaurus. So we search for the second time in the same search field but with 'notdefined' == 008/11='z' instead of the original thesaurus taken from subfield $2 of the bibliographic field 6XX.) This means we have to explicitly check the content of 040 $f of the resulting authority record. Test plan: ========== 1. Turn on the LinkerConsiderThesaurus systempreference. 2. Create an authority record (e.g. TOPIC_TERM) with 008/11 = 'z' and 040 $f containing a thesaurus indication (e.g. 'kaba'), and a term in field 150 $a (e.g. Early music). 3. Edit a bibliographic record: in field 650 put 2nd indicator '7', the term 'Early music' in $a, and a different thesaurus code in $2 (e.g. 'dbn'). Click the 'Link authorities automatically' button. Note that 650 'Early music' (dbn) has been linked with and authority record 'Early music' (kaba). This is wrong. 4. Apply the patch ; restart_all ; reindex ES for authorities with: koha-elasticsearch --rebuild -d -a kohadev 5. Repeat p. 3. Now the 650 'Early music' (dbn) has not been linked to an authority record (650 - No matching authority found.) Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181205|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182183&action=edit Bug 39503: Collapse thesaurus if value in 008_/11 = 'z' and 040 $f With bug 30280 and subsequent patches we attempt to respect the thesaurus indication when linking with LinkerConsiderThesaurus on. However, there are still cases when we link wrong. This happens when thesaurus in bibliographic field 6XX is defined by subfield $2. In such a case the authority record should have 008/11 = 'z' and, according to https://www.loc.gov/marc/authority/ad008.html (cf. comment for 008/11 = 'z': "A MARC code for the conventions used to formulate the heading *may* be contained in subfield $f"), may or may have thesaurus declared in 040 $f. This is why we make a second search attempt in C4::Heading::_search, but doing so we have to make sure that the resulting authority record has not a different thesaurus declared in 040 $f. (Note that 008/11 and 040 $f are indexed with the same search field: subject-heading-thesaurus. So we search for the second time in the same search field but with 'notdefined' == 008/11='z' instead of the original thesaurus taken from subfield $2 of the bibliographic field 6XX.) This means we have to explicitly check the content of 040 $f of the resulting authority record. Test plan: ========== 1. Turn on the LinkerConsiderThesaurus systempreference. 2. Create an authority record (e.g. TOPIC_TERM) with 008/11 = 'z' and 040 $f containing a thesaurus indication (e.g. 'kaba'), and a term in field 150 $a (e.g. Early music). 3. Edit a bibliographic record: in field 650 put 2nd indicator '7', the term 'Early music' in $a, and a different thesaurus code in $2 (e.g. 'dbn'). Click the 'Link authorities automatically' button. Note that 650 'Early music' (dbn) has been linked with and authority record 'Early music' (kaba). This is wrong. 4. Apply the patch ; restart_all ; reindex ES for authorities with: koha-elasticsearch --rebuild -d -a kohadev 5. Repeat p. 3. Now the 650 'Early music' (dbn) has not been linked to an authority record (650 - No matching authority found.) Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39503 --- Comment #17 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Katrin Fischer from comment #15)

The bug description mentions LinkerConsiderThesaurus, but I don't spot any code checking for the preference in the patch set?

This is because my original version of the patch (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180082&action=diff) referred to C4/Heading.pm (and the snippet was executed only if LinkerConsiderThesaurus was set). Now, the bug could be named after the patch title, like "Collapse elasticsearch subject-heading-thesaurus search field if value in 008_/11 = 'z' and 040 $f" or somehow similar. -- You are receiving this mail because: You are watching all bug changes.