[Bug 31633] New: Allow selection of branch to be applied in quick spine label CSS class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Bug ID: 31633 Summary: Allow selection of branch to be applied in quick spine label CSS class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org Depends on: 28512 Bug 28512 makes the quick spine label include a css class of the logged-in library to facilitate branch-specific customization of labels. Some libraries may prefer that the spine label formatting key off of the item's homebranch or holdingbranch, rather than the user's logged-in branch. Maybe a system preference to select which branch to apply? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- What if we just simply added a data-attribute that one could base CSS/JS off of? Something like: <div data-holdingbranch="CPL"> <div data-homebranch="FPL"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Lucas Gass from comment #1)
What if we just simply added a data-attribute that one could base CSS/JS off of?
Something like:
<div data-holdingbranch="CPL"> <div data-homebranch="FPL">
So just put all three branches in the CSS to start and let folks key off whichever they want to use? Works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #2)
(In reply to Lucas Gass from comment #1)
What if we just simply added a data-attribute that one could base CSS/JS off of?
Something like:
<div data-holdingbranch="CPL"> <div data-homebranch="FPL">
So just put all three branches in the CSS to start and let folks key off whichever they want to use? Works for me.
Yep, great idea :) I think if we could add them to the existing div, we would also be safe to not change the page structure affecting existing CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141035&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- I did a bad paste. The example CSS for testing is this: #spinelabel[data-holdingbranch="CPL"] { background: red; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |lucas@bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141035|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141036&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141036|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 141037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141037&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Allow selection of branch |Add home and holding data |to be applied in quick |attributes to quick spine |spine label CSS class |label print to help | |customizing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141037|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141188&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141188|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141189&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141189|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141190&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141191&action=edit Bug 31633: (QA follow-up) Add data-attribute for logged-in library The class has some advantages, but I thought it would be nice to also have the complete set of options in data-attributes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141283&action=edit Bug 31633: (follow-up) Group template params Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Bug 31633 depends on bug 28512, which changed state. Bug 28512 Summary: Quick spine label creator: Add CSS class with logged in library's branchcode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org