[Bug 16667] New: Unused variable and function call in circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Bug ID: 16667 Summary: Unused variable and function call in circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Variable is defined and never used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 52062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52062&action=edit Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52062|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 52067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52067&action=edit [SIGNED-OFF] Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #1)
This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite.
Not at all, it's not used since... commit 2ffd5b7228f4e638583162d483e1dd2febeafe1b Date: Fri Mar 9 14:28:54 2007 +0000 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52067|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52112&action=edit Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org