[Bug 16540] New: Translatability in opac-auth.tt (tag-isolated word 'Logout')
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Bug ID: 16540 Summary: Translatability in opac-auth.tt (tag-isolated word 'Logout') Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In opac-auth.tt, the sentence 'Logout and try with a different user' is splitted by a-tags. It is difficult to determine the translation of the isolated word 'Logout' (e.g. in German: 'Abmeldung' or 'Abmelden' or 'Melden Sie sich ab') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #1 from Marc Véron <veron@veron.ch> --- Additional issue: <p>If you want to, you can try to <a href="/cgi-bin/koha/svc/auth/googleopenidconnect?reauthenticate=select_account">log in using a different account</a> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability in |Translatability in |opac-auth.tt (tag-isolated |opac-auth.tt (tag-splitted |word 'Logout') |sentences) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51735&action=edit Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences) This patch removes tag-splitting from 2 sentences in pac-auth.tt To test: - Review code changes and verify that sentences ar no longer splitted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Severity|enhancement |trivial Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51735|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 51776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51776&action=edit Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences) This patch removes tag-splitting from 2 sentences in pac-auth.tt To test: - Review code changes and verify that following sentences are no longer splitted by <a>-tags: "Logout and try again with a different user" "Try to log in using a different Google account" UPDATE: Amended to fix a tiny typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51776|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 51911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51911&action=edit [SIGNED-OFF] Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences) This patch removes tag-splitting from 2 sentences in pac-auth.tt To test: - Review code changes and verify that following sentences are no longer splitted by <a>-tags: "Logout and try again with a different user" "Try to log in using a different Google account" UPDATE: Amended to fix a tiny typo Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just a dumb question: But don't we have other (easy) ways to achieve the same? Just hope so. Now, we end up with large clickable texts (read: <a> tags).. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #6 from Marc Véron <veron@veron.ch> --- (In reply to Marcel de Rooy from comment #5)
Just a dumb question: But don't we have other (easy) ways to achieve the same? Just hope so. Now, we end up with large clickable texts (read: <a> tags)..
I considered to have something like having an unlinked text as explanation followed by a link, something like: "Logout and try again with a different user. <a..>Click here</>" ... but I do not think that that would be nicer. Anyway, I agree with every solution that does not lead to messy / incorrect translations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16620 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #7 from Marc Véron <veron@veron.ch> --- There are more issues, opac-auth.tt lines 90 and following. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #8 from Marc Véron <veron@veron.ch> --- I went through the file to locate more translation issues. The current indentation makes it difficult to read. That's why I'll try to clean up indentation as well. Otherwise it is difficult to be sure that changes do not have unwanted side effects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 51945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51945&action=edit Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I see one typo: "<p>If you have a CAS account, please please choose against which one you would like to authenticate:</p>" There is an extra "please." As long as we are making changes to this page, I have a couple of other suggestions: - "Logout and try again with a different user" should use "Log out" instead. - "If you have a Shibboleth account, please click here to login." should use "log in" instead of "login." - "<p><a href="[% casServerUrl %]">Please click here to login.</a><p>" Use "log in" instead. - "<p><a href="[% casServerUrl %]">If you have a CAS account, please click here to login.</a><p>" Use "log in" instead. I looked for guidance for this on the terminology page on the wiki (https://wiki.koha-community.org/wiki/Terminology) and could not find it, but in my opinion it is analogous to this rule: "Use 'checkout' as a noun, 'check out' as a verb." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51945|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 51950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51950&action=edit Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51950|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51951&action=edit [SIGNED-OFF] Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51951|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52154&action=edit Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org