https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 [Bug 35761] Add an administration editor for FTP and SFTP servers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #1 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175204&action=edit Bug 35761: Integrate EDI into new FTP/SFTP management UI This patch integrates the EDI Transport.pm module into the new FTP/SFTP management UI by tweaking the existing methods to look at the new SftpServer object, instead of its own. Included also is a change to the database structure to make use of the new sftp_servers table, as well as an atomic update to copy the schema changes, and existing config to the new sftp_servers table. NOTE: To test this bug, you'll need to have access to a valid FTP/SFTP server, within which you are able to generate exemplar quotes, orders, and invoices. If you do not have access to this, contact me, and I will try to arrange something. Thanks To test: a) Apply Bug 35761, follow that test plan, and enable EDIFACT syspref b) Notice how there is a duplication of FTP/SFTP details in Koha, between EDI and FTP/SFTP Servers c) APPLY THIS BUG, reset_all, and enable EDIFACT syspref d) Create an FTP/SFTP Server under Koha Administration -> FTP/SFTP Server e) Create an EDI account 1) Notice how there is now two dropdowns for upload & download server 2) Choose the same server for both options 3) Set valid download & upload directories 4) Enable quotes, orders, and invoices f) Run ./misc/cronjobs/edi_cron.pl 1) Check that a quote is now in Koha from the EDI vendor 2) Confirm the quote via the staff client g) Run ./misc/cronjobs/edi_cron.pl 1) Check that the order is now on the FTP/SFTP server 2) Generate an invoice on the FTP/SFTP server h) Run ./misc/cronjobs/edi_cron.pl 1) Confirm Koha has received the invoice 2) Mark the invoice as paid in the staff client i) Run ./misc/cronjobs/edi_cron.pl 1) Check that the invoice is now on the FTP/SFTP server j) SIGN OFF! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #3 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175206&action=edit Bug 38489: Integrate EDI into new FTP/SFTP management UI This patch integrates the EDI Transport.pm module into the new FTP/SFTP management UI by tweaking the existing methods to look at the new SftpServer object, instead of its own. Included also is a change to the database structure to make use of the new sftp_servers table, as well as an atomic update to copy the schema changes, and existing config to the new sftp_servers table. NOTE: To test this bug, you'll need to have access to a valid FTP/SFTP server, within which you are able to generate exemplar quotes, orders, and invoices. If you do not have access to this, contact me, and I will try to arrange something. Thanks To test: a) Apply Bug 35761, follow that test plan, and enable EDIFACT syspref b) Notice how there is a duplication of FTP/SFTP details in Koha, between EDI and FTP/SFTP Servers c) APPLY THIS BUG, reset_all, and enable EDIFACT syspref d) Create an FTP/SFTP Server under Koha Administration -> FTP/SFTP Server e) Create an EDI account 1) Notice how there is now two dropdowns for upload & download server 2) Choose the same server for both options 3) Set valid download & upload directories 4) Enable quotes, orders, and invoices f) Run ./misc/cronjobs/edi_cron.pl 1) Check that a quote is now in Koha from the EDI vendor 2) Confirm the quote via the staff client g) Run ./misc/cronjobs/edi_cron.pl 1) Check that the order is now on the FTP/SFTP server 2) Generate an invoice on the FTP/SFTP server h) Run ./misc/cronjobs/edi_cron.pl 1) Confirm Koha has received the invoice 2) Mark the invoice as paid in the staff client i) Run ./misc/cronjobs/edi_cron.pl 1) Check that the invoice is now on the FTP/SFTP server j) SIGN OFF! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|EDI should be updated to |EDI should be updated to |use the new FTP/SFTP |use the new FTP/SFTP |Servers management tool |Servers management page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175206|0 |1 is obsolete| | --- Comment #5 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 176118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176118&action=edit Bug 38489: Integrate EDI into new FTP/SFTP management UI This patch integrates the EDI Transport.pm module into the new FTP/SFTP management UI by tweaking the existing methods to look at the new SftpServer object, instead of its own. Included also is a change to the database structure to make use of the new sftp_servers table, as well as an atomic update to copy the schema changes, and existing config to the new sftp_servers table. NOTE: To test this bug, you'll need to have access to a valid FTP/SFTP server, within which you are able to generate exemplar quotes, orders, and invoices. If you do not have access to this, contact me, and I will try to arrange something. Thanks To test: a) Apply Bug 35761, follow that test plan, and enable EDIFACT syspref b) Notice how there is a duplication of FTP/SFTP details in Koha, between EDI and FTP/SFTP Servers c) APPLY THIS BUG, reset_all, and enable EDIFACT syspref d) Create an FTP/SFTP Server under Koha Administration -> FTP/SFTP Server e) Create an EDI account 1) Notice how there is now two dropdowns for upload & download server 2) Choose the same server for both options 3) Set valid download & upload directories 4) Enable quotes, orders, and invoices f) Run ./misc/cronjobs/edi_cron.pl 1) Check that a quote is now in Koha from the EDI vendor 2) Confirm the quote via the staff client g) Run ./misc/cronjobs/edi_cron.pl 1) Check that the order is now on the FTP/SFTP server 2) Generate an invoice on the FTP/SFTP server h) Run ./misc/cronjobs/edi_cron.pl 1) Confirm Koha has received the invoice 2) Mark the invoice as paid in the staff client i) Run ./misc/cronjobs/edi_cron.pl 1) Check that the invoice is now on the FTP/SFTP server j) SIGN OFF! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176119|0 |1 is obsolete| | --- Comment #7 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 176161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176161&action=edit Bug 38489: (follow-up) tidy EDIfact files This patch follows-up by by tidying the following files: * Koha/Edifact/Transport.pm * admin/edi_accounts.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176118|0 |1 is obsolete| | --- Comment #9 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 185324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185324&action=edit Bug 38489: Integrate EDI into new FTP/SFTP management UI This patch integrates the EDI Transport.pm module into the new FTP/SFTP management UI by tweaking the existing methods to look at the new SftpServer object, instead of its own. Included also is a change to the database structure to make use of the new sftp_servers table, as well as an atomic update to copy the schema changes, and existing config to the new sftp_servers table. NOTE: To test this bug, you'll need to have access to a valid FTP/SFTP server, within which you are able to generate exemplar quotes, orders, and invoices. If you do not have access to this, contact me, and I will try to arrange something. Thanks To test: a) Apply Bug 35761, follow that test plan, and enable EDIFACT syspref b) Notice how there is a duplication of FTP/SFTP details in Koha, between EDI and FTP/SFTP Servers c) APPLY THIS BUG, reset_all, and enable EDIFACT syspref d) Create an FTP/SFTP Server under Koha Administration -> FTP/SFTP Server e) Create an EDI account 1) Notice how there is now two dropdowns for upload & download server 2) Choose the same server for both options 3) Set valid download & upload directories 4) Enable quotes, orders, and invoices f) Run ./misc/cronjobs/edi_cron.pl 1) Check that a quote is now in Koha from the EDI vendor 2) Confirm the quote via the staff client g) Run ./misc/cronjobs/edi_cron.pl 1) Check that the order is now on the FTP/SFTP server 2) Generate an invoice on the FTP/SFTP server h) Run ./misc/cronjobs/edi_cron.pl 1) Confirm Koha has received the invoice 2) Mark the invoice as paid in the staff client i) Run ./misc/cronjobs/edi_cron.pl 1) Check that the invoice is now on the FTP/SFTP server j) SIGN OFF! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Jake Deery <jake.deery@openfifth.co.uk> --- Just obsoleted the tidy patch, and attached a new work. Hopefully this should still all behave itself (I had a short test run, worksforme, though some additional thoroughness from someone else in Community would be appreciated). Ta, Jake. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185324|0 |1 is obsolete| | --- Comment #11 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 186819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186819&action=edit Bug 38489: Integrate EDI into new FTP/SFTP management UI This patch integrates the EDI Transport.pm module into the new FTP/SFTP management UI by tweaking the existing methods to look at the new SftpServer object, instead of its own. Included also is a change to the database structure to make use of the new sftp_servers table, as well as an atomic update to copy the schema changes, and existing config to the new sftp_servers table. NOTE: To test this bug, you'll need to have access to a valid FTP/SFTP server, within which you are able to generate exemplar quotes, orders, and invoices. If you do not have access to this, contact me, and I will try to arrange something. Thanks To test: a) Apply Bug 35761, follow that test plan, and enable EDIFACT syspref b) Notice how there is a duplication of FTP/SFTP details in Koha, between EDI and FTP/SFTP Servers c) APPLY THIS BUG, reset_all, and enable EDIFACT syspref d) Create an FTP/SFTP Server under Koha Administration -> FTP/SFTP Server e) Create an EDI account 1) Notice how there is now two dropdowns for upload & download server 2) Choose the same server for both options 3) Set valid download & upload directories 4) Enable quotes, orders, and invoices f) Run ./misc/cronjobs/edi_cron.pl 1) Check that a quote is now in Koha from the EDI vendor 2) Confirm the quote via the staff client g) Run ./misc/cronjobs/edi_cron.pl 1) Check that the order is now on the FTP/SFTP server 2) Generate an invoice on the FTP/SFTP server h) Run ./misc/cronjobs/edi_cron.pl 1) Confirm Koha has received the invoice 2) Mark the invoice as paid in the staff client i) Run ./misc/cronjobs/edi_cron.pl 1) Check that the invoice is now on the FTP/SFTP server j) SIGN OFF! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #13 from Jake Deery <jake.deery@openfifth.co.uk> --- Another rebase..! Also, split out the DBIC code for easier pushing to main. Ta, Jake. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186846&action=edit Bug 38489: Update EDI accounts UI to use file transport selection This patch updates the EDI accounts administration interface to use the new file_transports system instead of direct transport configuration. Changes: - Replace transport configuration fields with transport selection dropdown - Add file_transports data to template for selection options - Remove password decryption since credentials are now managed by transports - Simplify form handling to only manage EDI-specific fields - Add helpful link to file transport administration -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186848&action=edit Bug 38489: Add disconnect method and proper connection cleanup to file transport system This patch adds proper connection cleanup functionality to the file transport system, addressing a gap identified during EDI migration. Changes: - Add disconnect() method to base Transport class interface - Implement SFTP disconnect using connection->disconnect() - Implement FTP disconnect using connection->quit() - Add DESTROY methods to ensure connections are cleaned up on object destruction - Local transport includes no-op disconnect for API consistency This ensures that FTP/SFTP connections are properly closed, preventing connection leaks and potential resource exhaustion issues. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186850&action=edit Bug 38489: Update Koha::Edifact::Transport to use new file transport system This patch completely refactors the EDI transport handling to use the modern file_transports system instead of legacy direct connections. Changes: - Remove legacy FTP/SFTP connection code - Update constructor to load file_transport from vendor_edi_accounts - Update download_messages/upload_messages to use modern transport methods - Use new rename_file() method for EDI file processing workflow - Remove dependencies on Net::FTP and Net::SFTP::Foreign - Maintain all EDI-specific functionality (file filtering, ingestion) Cleanup: - Remove obsolete methods: file_download, sftp_download, ftp_download, sftp_upload, ftp_upload, file_upload, _abort_download - Update POD documentation to reflect new architecture - 184 lines of legacy code removed The transport system now provides: - Unified connection handling across all transport types - Enhanced error reporting and status tracking - Encrypted credential storage - Connection testing capabilities - Support for local directories (testing/development) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186852&action=edit Bug 38489: Update EDI tests to use new file transport system The EDI test was still creating vendor_edi_accounts with transport='FILE' which no longer works after the migration to the file_transports system. Updated all test account creation to: - Create file_transports records with transport='local' - Link EDI accounts via file_transport_id instead of direct transport field - Set appropriate download/upload directories for local testing All EDI tests now pass with the new transport architecture. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Sorry Jake, I started to review this knowing that a fair chunk had changed under the hood since you last looked. I'm afraid it highlighted a few oversights in your rebase, but more importantly, a few oversights in the work I did reworking the Transport classes behind the scenes.. As such, I've knicked the bug and added a set of patches that I believe now do the right thing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186854&action=edit Bug 38489: Standardize FTP transport API to match SFTP and Local classes Fix several API inconsistencies in the FTP transport class: 1. Message format: Use standardized `message => $operation` format instead of hardcoded strings like "Upload succeeded" 2. Operation tracking: Add $operation variable to all methods for consistent error reporting and logging 3. Error handling: Update _abort_operation() to accept operation parameter and provide more detailed error payloads 4. Success payloads: Replace empty `detail => ''` payloads with meaningful operation-specific information (host, port, file paths, directory info, file counts) All transport classes now have consistent APIs for: - Standardized message formats - Consistent operation tracking - Uniform error handling - Informative success payloads -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38629 [Bug 38629] Update sftp_file.pl to support the new SFTP configurations page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 [Bug 20253] Optionally use buyer's purchase order number from EDIFACT quote in basket name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187080&action=edit Bug 38489: Follow-up to bug 39190 to fix administration We did some last minute renaming of things in bug 39190 but didn't catch all the places. This patch updates the old 'sftp_servers' naming scheme to 'file_transports' following the new pattern and restores edit and delete functionality in the File transports management area. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186846|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187082&action=edit Bug 38489: Update EDI accounts UI to use file transport selection This patch updates the EDI accounts administration interface to use the new file_transports system instead of direct transport configuration. Changes: - Replace transport configuration fields with transport selection dropdown - Add file_transports data to template for selection options - Remove password decryption since credentials are now managed by transports - Simplify form handling to only manage EDI-specific fields - Add helpful link to file transport administration Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186848|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187084&action=edit Bug 38489: Add disconnect method and proper connection cleanup to file transport system This patch adds proper connection cleanup functionality to the file transport system, addressing a gap identified during EDI migration. Changes: - Add disconnect() method to base Transport class interface - Implement SFTP disconnect using connection->disconnect() - Implement FTP disconnect using connection->quit() - Add DESTROY methods to ensure connections are cleaned up on object destruction - Local transport includes no-op disconnect for API consistency This ensures that FTP/SFTP connections are properly closed, preventing connection leaks and potential resource exhaustion issues. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186850|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187086&action=edit Bug 38489: Update Koha::Edifact::Transport to use new file transport system This patch completely refactors the EDI transport handling to use the modern file_transports system instead of legacy direct connections. Changes: - Remove legacy FTP/SFTP connection code - Update constructor to load file_transport from vendor_edi_accounts - Update download_messages/upload_messages to use modern transport methods - Use new rename_file() method for EDI file processing workflow - Remove dependencies on Net::FTP and Net::SFTP::Foreign - Maintain all EDI-specific functionality (file filtering, ingestion) Cleanup: - Remove obsolete methods: file_download, sftp_download, ftp_download, sftp_upload, ftp_upload, file_upload, _abort_download - Update POD documentation to reflect new architecture - 184 lines of legacy code removed The transport system now provides: - Unified connection handling across all transport types - Enhanced error reporting and status tracking - Encrypted credential storage - Connection testing capabilities - Support for local directories (testing/development) Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186852|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187088&action=edit Bug 38489: Update EDI tests to use new file transport system The EDI test was still creating vendor_edi_accounts with transport='FILE' which no longer works after the migration to the file_transports system. Updated all test account creation to: - Create file_transports records with transport='local' - Link EDI accounts via file_transport_id instead of direct transport field - Set appropriate download/upload directories for local testing All EDI tests now pass with the new transport architecture. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187108&action=edit Bug 38489: (follow-up) Use 'TableExists' in atomicupdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- My mistake.. you mean the display table on the edi accounts management page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187147&action=edit Bug 38489: (follow-up) Update EDI accounts list display This patch updates the EDI accounts management page to display the new file transport system instead of the old inline transport configuration fields. Changes: - Replaced multiple transport-related columns (Transport, Remote host, Username, Password, Upload/Download ports and directories) with a single "File transport" column - The file transport column displays the transport name with its connection test status in brackets - Status indicators match the file_transports page: * "Tests passing" (green with checkmark icon) for successful tests * "Errors detected" (red with x icon) for failed tests * "Never used" (italic) for untested transports - Updated the Perl controller to decode the JSON status field from the file_transports table and pass it to the template - Uses get_inflated_columns to convert DBIx::Class results to plain hashrefs for template consumption The display now correctly reflects the architectural change where transport configuration is managed separately in the file_transports table rather than duplicated in each EDI account. Note: At a future date we should replace the raw DBIx::Class methods with Koha::Object based classes. I propose Koha::EDI::Account(s). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187080|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187148&action=edit Bug 38489: Follow-up to bug 39190 to fix administration We did some last minute renaming of things in bug 39190 but didn't catch all the places. This patch updates the old 'sftp_servers' naming scheme to 'file_transports' following the new pattern and restores edit and delete functionality in the File transports management area. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187082|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187150&action=edit Bug 38489: Update EDI accounts UI to use file transport selection This patch updates the EDI accounts administration interface to use the new file_transports system instead of direct transport configuration. Changes: - Replace transport configuration fields with transport selection dropdown - Add file_transports data to template for selection options - Remove password decryption since credentials are now managed by transports - Simplify form handling to only manage EDI-specific fields - Add helpful link to file transport administration Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187084|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187152&action=edit Bug 38489: Add disconnect method and proper connection cleanup to file transport system This patch adds proper connection cleanup functionality to the file transport system, addressing a gap identified during EDI migration. Changes: - Add disconnect() method to base Transport class interface - Implement SFTP disconnect using connection->disconnect() - Implement FTP disconnect using connection->quit() - Add DESTROY methods to ensure connections are cleaned up on object destruction - Local transport includes no-op disconnect for API consistency This ensures that FTP/SFTP connections are properly closed, preventing connection leaks and potential resource exhaustion issues. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187086|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187154&action=edit Bug 38489: Update Koha::Edifact::Transport to use new file transport system This patch completely refactors the EDI transport handling to use the modern file_transports system instead of legacy direct connections. Changes: - Remove legacy FTP/SFTP connection code - Update constructor to load file_transport from vendor_edi_accounts - Update download_messages/upload_messages to use modern transport methods - Use new rename_file() method for EDI file processing workflow - Remove dependencies on Net::FTP and Net::SFTP::Foreign - Maintain all EDI-specific functionality (file filtering, ingestion) Cleanup: - Remove obsolete methods: file_download, sftp_download, ftp_download, sftp_upload, ftp_upload, file_upload, _abort_download - Update POD documentation to reflect new architecture - 184 lines of legacy code removed Removed imports: - use DateTime; - Not used, dt_from_string() used instead - use English qw{ -no_match_vars }; - No English variables used - use File::Copy qw( copy move ); - File operations now handled by Koha::File::Transport internally The transport system now provides: - Unified connection handling across all transport types - Enhanced error reporting and status tracking - Encrypted credential storage - Connection testing capabilities - Support for local directories (testing/development) Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187088|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187156&action=edit Bug 38489: Update EDI tests to use new file transport system The EDI test was still creating vendor_edi_accounts with transport='FILE' which no longer works after the migration to the file_transports system. Updated all test account creation to: - Create file_transports records with transport='local' - Link EDI accounts via file_transport_id instead of direct transport field - Set appropriate download/upload directories for local testing All EDI tests now pass with the new transport architecture. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187108|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187158&action=edit Bug 38489: (follow-up) Use 'TableExists' in atomicupdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #53 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187270&action=edit Bug 38489: (follow-up) Update EDI accounts list display Patch from commit 0f82848 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #55 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187272&action=edit Bug 38489: Standardize FTP transport API to match SFTP and Local classes Patch from commit 8ed390d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #57 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187274&action=edit Bug 38489: Schema Update Patch from commit b8a3a58 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #59 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187276&action=edit Bug 38489: Standardize list_files API across all transport classes Patch from commit be5bbe4 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #61 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187278&action=edit Bug 38489: Add rename_file method to transport system and Local transport class Patch from commit a7d5087 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #63 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187280&action=edit Bug 38489: Add file_transport_id to vendor_edi_accounts and migrate to new transport system Patch from commit 50849f7 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187148|0 |1 is obsolete| | Attachment #187149|0 |1 is obsolete| | Attachment #187150|0 |1 is obsolete| | Attachment #187151|0 |1 is obsolete| | Attachment #187152|0 |1 is obsolete| | Attachment #187153|0 |1 is obsolete| | Attachment #187154|0 |1 is obsolete| | Attachment #187155|0 |1 is obsolete| | Attachment #187156|0 |1 is obsolete| | Attachment #187157|0 |1 is obsolete| | Attachment #187158|0 |1 is obsolete| | Attachment #187159|0 |1 is obsolete| | Attachment #187270|0 |1 is obsolete| | Attachment #187271|0 |1 is obsolete| | Attachment #187272|0 |1 is obsolete| | Attachment #187273|0 |1 is obsolete| | Attachment #187274|0 |1 is obsolete| | Attachment #187275|0 |1 is obsolete| | Attachment #187276|0 |1 is obsolete| | Attachment #187277|0 |1 is obsolete| | Attachment #187278|0 |1 is obsolete| | Attachment #187279|0 |1 is obsolete| | Attachment #187280|0 |1 is obsolete| | Attachment #187281|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187283&action=edit Bug 38489: Follow-up to bug 39190 to fix administration We did some last minute renaming of things in bug 39190 but didn't catch all the places. This patch updates the old 'sftp_servers' naming scheme to 'file_transports' following the new pattern and restores edit and delete functionality in the File transports management area. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #67 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187285&action=edit Bug 38489: Update EDI accounts UI to use file transport selection This patch updates the EDI accounts administration interface to use the new file_transports system instead of direct transport configuration. Changes: - Replace transport configuration fields with transport selection dropdown - Add file_transports data to template for selection options - Remove password decryption since credentials are now managed by transports - Simplify form handling to only manage EDI-specific fields - Add helpful link to file transport administration Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #69 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187287&action=edit Bug 38489: Add disconnect method and proper connection cleanup to file transport system This patch adds proper connection cleanup functionality to the file transport system, addressing a gap identified during EDI migration. Changes: - Add disconnect() method to base Transport class interface - Implement SFTP disconnect using connection->disconnect() - Implement FTP disconnect using connection->quit() - Add DESTROY methods to ensure connections are cleaned up on object destruction - Local transport includes no-op disconnect for API consistency This ensures that FTP/SFTP connections are properly closed, preventing connection leaks and potential resource exhaustion issues. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #71 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187289&action=edit Bug 38489: Update Koha::Edifact::Transport to use new file transport system This patch completely refactors the EDI transport handling to use the modern file_transports system instead of legacy direct connections. Changes: - Remove legacy FTP/SFTP connection code - Update constructor to load file_transport from vendor_edi_accounts - Update download_messages/upload_messages to use modern transport methods - Use new rename_file() method for EDI file processing workflow - Remove dependencies on Net::FTP and Net::SFTP::Foreign - Maintain all EDI-specific functionality (file filtering, ingestion) Cleanup: - Remove obsolete methods: file_download, sftp_download, ftp_download, sftp_upload, ftp_upload, file_upload, _abort_download - Update POD documentation to reflect new architecture - 184 lines of legacy code removed Removed imports: - use DateTime; - Not used, dt_from_string() used instead - use English qw{ -no_match_vars }; - No English variables used - use File::Copy qw( copy move ); - File operations now handled by Koha::File::Transport internally The transport system now provides: - Unified connection handling across all transport types - Enhanced error reporting and status tracking - Encrypted credential storage - Connection testing capabilities - Support for local directories (testing/development) Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #73 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187291&action=edit Bug 38489: Update EDI tests to use new file transport system The EDI test was still creating vendor_edi_accounts with transport='FILE' which no longer works after the migration to the file_transports system. Updated all test account creation to: - Create file_transports records with transport='local' - Link EDI accounts via file_transport_id instead of direct transport field - Set appropriate download/upload directories for local testing All EDI tests now pass with the new transport architecture. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #75 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187293&action=edit Bug 38489: (follow-up) Use 'TableExists' in atomicupdate Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187283|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187861&action=edit Bug 38489: Follow-up to bug 39190 to fix administration We did some last minute renaming of things in bug 39190 but didn't catch all the places. This patch updates the old 'sftp_servers' naming scheme to 'file_transports' following the new pattern and restores edit and delete functionality in the File transports management area. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187285|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187863&action=edit Bug 38489: Update EDI accounts UI to use file transport selection This patch updates the EDI accounts administration interface to use the new file_transports system instead of direct transport configuration. Changes: - Replace transport configuration fields with transport selection dropdown - Add file_transports data to template for selection options - Remove password decryption since credentials are now managed by transports - Simplify form handling to only manage EDI-specific fields - Add helpful link to file transport administration Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187287|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187865&action=edit Bug 38489: Add disconnect method and proper connection cleanup to file transport system This patch adds proper connection cleanup functionality to the file transport system, addressing a gap identified during EDI migration. Changes: - Add disconnect() method to base Transport class interface - Implement SFTP disconnect using connection->disconnect() - Implement FTP disconnect using connection->quit() - Add DESTROY methods to ensure connections are cleaned up on object destruction - Local transport includes no-op disconnect for API consistency This ensures that FTP/SFTP connections are properly closed, preventing connection leaks and potential resource exhaustion issues. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187289|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187867&action=edit Bug 38489: Update Koha::Edifact::Transport to use new file transport system This patch completely refactors the EDI transport handling to use the modern file_transports system instead of legacy direct connections. Changes: - Remove legacy FTP/SFTP connection code - Update constructor to load file_transport from vendor_edi_accounts - Update download_messages/upload_messages to use modern transport methods - Use new rename_file() method for EDI file processing workflow - Remove dependencies on Net::FTP and Net::SFTP::Foreign - Maintain all EDI-specific functionality (file filtering, ingestion) Cleanup: - Remove obsolete methods: file_download, sftp_download, ftp_download, sftp_upload, ftp_upload, file_upload, _abort_download - Update POD documentation to reflect new architecture - 184 lines of legacy code removed Removed imports: - use DateTime; - Not used, dt_from_string() used instead - use English qw{ -no_match_vars }; - No English variables used - use File::Copy qw( copy move ); - File operations now handled by Koha::File::Transport internally The transport system now provides: - Unified connection handling across all transport types - Enhanced error reporting and status tracking - Encrypted credential storage - Connection testing capabilities - Support for local directories (testing/development) Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187291|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187869&action=edit Bug 38489: Update EDI tests to use new file transport system The EDI test was still creating vendor_edi_accounts with transport='FILE' which no longer works after the migration to the file_transports system. Updated all test account creation to: - Create file_transports records with transport='local' - Link EDI accounts via file_transport_id instead of direct transport field - Set appropriate download/upload directories for local testing All EDI tests now pass with the new transport architecture. Sponsored-by: ByWater Solutions Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187293|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187871&action=edit Bug 38489: (follow-up) Use 'TableExists' in atomicupdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #90 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187873&action=edit Bug 38489: (follow-up) Update bug 40587 tests We pushed bug 40587 since this bug Passed QA. It introduces a new test using the older construct, so this patch updates that test to add the new construct by building a File::Transport. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41020 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #94 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #93)

I see this failure now when upgrading:

Upgrade to 22.12.00.041 [22:16:32]: Bug 30649 - Increase the vendor EDI account password field to 256 characters ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column 'password' in 'vendor_edi_accounts' at /kohadevbox/koha/C4/Installer.pm line 825

Looks like the db update didn't get moved from atomicupdates to db_revs, but I doubt that's the issue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #96 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187916&action=edit Bug 38489: (follow-up) Make old db_rev more idempotent In the unit test system we reset the database version to 21.11 after having upgraded a long way past that. The 221200041 update appears not to be fully idempotent, so we fail running through the upgrade. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187916|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187923&action=edit Bug 38489: (follow-up) Make old db_rev more idempotent In the unit test system we reset the database version to 21.11 after having upgraded a long way past that. The 221200041 update appears not to be fully idempotent, so we fail running through the upgrade. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 --- Comment #100 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187925&action=edit Bug 38489: (follow-up) Improve idempotency of update We needed better idempotency around checking for fields before attempting to use them during migration and then dropping them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #102 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- all follow-ups pushed to main. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38629 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38629 [Bug 38629] Update sftp_file.pl to support the new SFTP configurations page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38195 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38195 [Bug 38195] EDI/Edifact classes should use Koha::Objects instead of plain DBIC -- You are receiving this mail because: You are watching all bug changes.