https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178555&action=edit Bug 39190: Add $result to Koha::Objects `object_class` calls This allows us to do dynamic polymorphic classing on calls to 'find', 'find_or_create', 'single', 'next', 'last' and 'as_list' etc. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178557&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178559&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178561&action=edit Bug 39190: DBIC Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178563&action=edit Bug 39190: Update api tests for status format change -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178565&action=edit Bug 39190: Remove old objects -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178567&action=edit Bug 39190: Remove replaced test_connection -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178569&action=edit Bug 39190: Update API's to reference new classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178571&action=edit Bug 39190: Skip polymorphic classes in TestBuilder tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178555|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179252&action=edit Bug 39190: Add $result to Koha::Objects `object_class` calls This allows us to do dynamic polymorphic classing on calls to 'find', 'find_or_create', 'single', 'next', 'last' and 'as_list' etc. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178557|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179254&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178559|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179256&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178561|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179258&action=edit Bug 39190: DBIC Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178563|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179260&action=edit Bug 39190: Update api tests for status format change -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178565|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179262&action=edit Bug 39190: Remove old objects -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178567|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179264&action=edit Bug 39190: Remove replaced test_connection -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178569|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179266&action=edit Bug 39190: Update API's to reference new classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178571|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179268&action=edit Bug 39190: Skip polymorphic classes in TestBuilder tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179252|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179396&action=edit Bug 39190: Add $result to Koha::Objects `object_class` calls This allows us to do dynamic polymorphic classing on calls to 'find', 'find_or_create', 'single', 'next', 'last' and 'as_list' etc. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179254|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179398&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179256|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179400&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179258|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179402&action=edit Bug 39190: DBIC Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179260|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179404&action=edit Bug 39190: Update api tests for status format change -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179262|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179406&action=edit Bug 39190: Remove old objects -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179264|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179408&action=edit Bug 39190: Remove replaced test_connection -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179266|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179410&action=edit Bug 39190: Update API's to reference new classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179412&action=edit Bug 39190: Use introspection in TestBuilder tests We update the testbuilder tests here to look for signs of a polymorphic class map and use it to test the different class options for this base class -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179396|0 |1 is obsolete| | Attachment #179397|0 |1 is obsolete| | Attachment #179398|0 |1 is obsolete| | Attachment #179399|0 |1 is obsolete| | Attachment #179400|0 |1 is obsolete| | Attachment #179401|0 |1 is obsolete| | Attachment #179402|0 |1 is obsolete| | Attachment #179403|0 |1 is obsolete| | Attachment #179404|0 |1 is obsolete| | Attachment #179405|0 |1 is obsolete| | Attachment #179406|0 |1 is obsolete| | Attachment #179407|0 |1 is obsolete| | Attachment #179408|0 |1 is obsolete| | Attachment #179409|0 |1 is obsolete| | Attachment #179410|0 |1 is obsolete| | Attachment #179411|0 |1 is obsolete| | Attachment #179412|0 |1 is obsolete| | Attachment #179413|0 |1 is obsolete| | --- Comment #54 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179589&action=edit Bug 39190: Add $result to Koha::Objects `object_class` calls This allows us to do dynamic polymorphic classing on calls to 'find', 'find_or_create', 'single', 'next', 'last' and 'as_list' etc. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #56 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179591&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #58 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179593&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #60 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179595&action=edit Bug 39190: DBIC Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #62 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179597&action=edit Bug 39190: Update api tests for status format change Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #64 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179599&action=edit Bug 39190: Remove old objects Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #66 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179601&action=edit Bug 39190: Remove replaced test_connection Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #68 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179603&action=edit Bug 39190: Update API's to reference new classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #70 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 179605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179605&action=edit Bug 39190: Use introspection in TestBuilder tests We update the testbuilder tests here to look for signs of a polymorphic class map and use it to test the different class options for this base class Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179589|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179646&action=edit Bug 39190: Add $result to Koha::Objects `object_class` calls This allows us to do dynamic polymorphic classing on calls to 'find', 'find_or_create', 'single', 'next', 'last' and 'as_list' etc. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179591|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179648&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179593|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179650&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179595|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179652&action=edit Bug 39190: DBIC Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179597|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179654&action=edit Bug 39190: Update api tests for status format change Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179599|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179656&action=edit Bug 39190: Remove old objects Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179601|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179658&action=edit Bug 39190: Remove replaced test_connection Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179603|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179660&action=edit Bug 39190: Update API's to reference new classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179605|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179662&action=edit Bug 39190: Use introspection in TestBuilder tests We update the testbuilder tests here to look for signs of a polymorphic class map and use it to test the different class options for this base class Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #91 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Kyle M Hall (khall) from comment #72)

Transport is listed twice in the form for sftp_servers.pl

Well spotted, fixed inline now :) Thanks for reviewing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179647|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 179992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179992&action=edit Bug 39190: Rework (S)FTP into File::Transport classes This patch adds polymorphic transport classes to Koha for FTP and SFTP file transport configurations. We introduce a base class for interacting with the base configuration storage and subclasses to impliment the protocol specific transport handling. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179649|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 179994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179994&action=edit Bug 39190: Update API to use new Transport classes As the title says, use the new polymorphic classes in the API controllers Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179651|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 179996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179996&action=edit Bug 39190: Update status to longtext Update status field to store longtext so we can sore more details information about connection statuses from test connection Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179653|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 179998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179998&action=edit Bug 39190: Re-implement the connection testing We now use background jobs triggered by Transport->store to update the connection status. Status is now a json blob with more details, so we update the api definition to reflect that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179655|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180000&action=edit Bug 39190: Start of recording status updates from abort Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179657|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180002&action=edit Bug 39190: Remove test routine from API Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179659|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180004&action=edit Bug 39190: Redirect Schema to new classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179661|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180006&action=edit Bug 39190: Add transport to test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179992|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180011&action=edit Bug 39190: Rework (S)FTP into File::Transport classes This patch adds polymorphic transport classes to Koha for FTP and SFTP file transport configurations. We introduce a base class for interacting with the base configuration storage and subclasses to impliment the protocol specific transport handling. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179994|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180013&action=edit Bug 39190: Update API to use new Transport classes As the title says, use the new polymorphic classes in the API controllers Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179996|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180015&action=edit Bug 39190: Update status to longtext Update status field to store longtext so we can sore more details information about connection statuses from test connection Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179998|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180017&action=edit Bug 39190: Re-implement the connection testing We now use background jobs triggered by Transport->store to update the connection status. Status is now a json blob with more details, so we update the api definition to reflect that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180000|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180019&action=edit Bug 39190: Start of recording status updates from abort Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180002|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180021&action=edit Bug 39190: Remove test routine from API Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180004|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180023&action=edit Bug 39190: Redirect Schema to new classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180006|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180025&action=edit Bug 39190: Add transport to test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179662|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180010|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185014&action=edit Bug 39190: Update polymorhpic base class to identify itself This patch adds _polymorphic_field and _polymorphic_map private methods to the Koha::File::Transports class to more clearly identify this as a polymorphic class base for TestBuilder. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180012|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185016&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180014|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185018&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180016|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185020&action=edit Bug 39190: DBIC Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180018|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185022&action=edit Bug 39190: Update api tests for status format change Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180020|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185024&action=edit Bug 39190: Remove old objects Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180022|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185026&action=edit Bug 39190: Remove replaced test_connection Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180024|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185028&action=edit Bug 39190: Update API's to reference new classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #140 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Julian Maurice from comment #123)

I think that polymorphism (at the Koha::Object level) is not the best solution here. I think the problem is that Koha::File::Transport tries to be many things at once: it is a database entity and a file transporter. Those are two very different things.

We already have (to some extent) some other classes that could be considered polymorphic: * Background jobs: implement the `_derived_class` method i.e. we search for Koha::BackgroundJob objects then call `->derived_class()` in the caller. This happens in the 'workers' * IdP classes: implement the `upgrade_class` method. Only used for OAuth at the moment but other cases coming (I submitted CAS and Shibboleth classes) * Koha::Account::Line: doesn't implement an upgrade method, Koha::Account can be used with `credits()` and `debits()` to retrieve certain type with the appropriate object type. We might need to revisit them. Will keep thinking about it over the weekend. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #142 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185973&action=edit Bug 39190: Rework (S)FTP into File::Transport classes This patch adds polymorphic transport classes to Koha for FTP and SFTP file transport configurations. We introduce a base class for interacting with the base configuration storage and subclasses to impliment the protocol specific transport handling. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #144 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185975&action=edit Bug 39190: Update API to use new Transport classes As the title says, use the new polymorphic classes in the API controllers Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #146 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185977&action=edit Bug 39190: Update status to longtext Update status field to store longtext so we can sore more details information about connection statuses from test connection Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #148 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185979&action=edit Bug 39190: Update api tests for status format change Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #150 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185981&action=edit Bug 39190: Remove old objects Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #152 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185983&action=edit Bug 39190: Remove replaced test_connection Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #154 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185985&action=edit Bug 39190: Update API's to reference new classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #156 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185987&action=edit Bug 39190: Rename 'sftp_servers' to 'file_transports' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #158 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185989&action=edit Bug 39190: Adjust permission across the board Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #160 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I haven't finished here. The SFTP.t failure hints the class resolution mechanism is flawed. And I think we should rename all 'sftp*' scripts and templates right away too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #162 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185995&action=edit Bug 39190: Fix polymorphic object creation in Koha::Objects This patch fixes polymorphic object creation by ensuring all methods in Koha::Objects that instantiate objects pass the DBIC result to the object_class() method for proper polymorphic resolution. Fixed methods: - find(): Now passes $result to object_class($result) - next(): Now passes $result to object_class($result) - _wrap(): Now passes $_ to object_class($_) in map This enables polymorphic classes like Koha::File::Transports to return the correct subclass (Koha::File::Transport::SFTP, Koha::File::Transport::FTP) based on the transport field value, instead of always returning the base Koha::File::Transport class. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/File/Transports.t \ t/db_dependent/Koha/File/Transport/SFTP.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #164 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185997&action=edit Bug 39190: Rename API from sftp_servers to file_transports This patch renames the entire API structure from SFTP-specific to generic file transport terminology to reflect the polymorphic nature of the system. API Changes: - Endpoints: /config/sftp_servers -> /config/file_transports - Parameters: sftp_server_id -> file_transport_id - Definitions: sftp_server -> file_transport - Controller: Config::SFTP::Servers -> Config::File::Transports File Changes: - api/v1/swagger/definitions/sftp_server.yaml -> file_transport.yaml - api/v1/swagger/paths/config_sftp_servers.yaml -> config_file_transports.yaml - Koha/REST/V1/Config/SFTP/Servers.pm -> Koha/REST/V1/Config/File/Transports.pm - t/db_dependent/api/v1/sftp_servers.t -> file_transports.t Updated References: - swagger.yaml: paths, definitions, parameters, tags - Template JavaScript: API URLs and variable names - Controller: package name, variable names, error messages - Tests: endpoints, parameters, descriptions - API mapping: to_api_mapping field name correction To test: 1. Apply this patch 2. Run: yarn api:bundle (to regenerate swagger bundle) 3. Run: prove t/db_dependent/api/v1/file_transports.t 4. All API tests should pass 5. Verify admin interface uses new API endpoints 6. Test CRUD operations work correctly The API now consistently uses 'file_transports' terminology matching the polymorphic file transport system that supports FTP, SFTP, and future transport types. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #166 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #160)

I haven't finished here. The SFTP.t failure hints the class resolution mechanism is flawed. And I think we should rename all 'sftp*' scripts and templates right away too.

I now finished what I believe this patchset should be like. It is all designed to be pushed in one shot along with bug 35761. RM: please don't push until Martin has given his blessing to the followups. I'm happy to roll back and start over if there's no agreement on some of it. Happy weekend! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #167 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Setting to BLOCKED until Bug 35761 is out of FQA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #168 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Looking good.. It has my blessing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185973|0 |1 is obsolete| | Attachment #185974|0 |1 is obsolete| | Attachment #185975|0 |1 is obsolete| | Attachment #185976|0 |1 is obsolete| | Attachment #185977|0 |1 is obsolete| | Attachment #185978|0 |1 is obsolete| | Attachment #185979|0 |1 is obsolete| | Attachment #185980|0 |1 is obsolete| | Attachment #185981|0 |1 is obsolete| | Attachment #185982|0 |1 is obsolete| | Attachment #185983|0 |1 is obsolete| | Attachment #185984|0 |1 is obsolete| | Attachment #185985|0 |1 is obsolete| | Attachment #185986|0 |1 is obsolete| | Attachment #185987|0 |1 is obsolete| | Attachment #185988|0 |1 is obsolete| | Attachment #185989|0 |1 is obsolete| | Attachment #185990|0 |1 is obsolete| | Attachment #185994|0 |1 is obsolete| | Attachment #185995|0 |1 is obsolete| | Attachment #185996|0 |1 is obsolete| | Attachment #185997|0 |1 is obsolete| | Attachment #185998|0 |1 is obsolete| | Attachment #186408|0 |1 is obsolete| | --- Comment #170 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186409&action=edit Bug 39190: Update polymorhpic base class to identify itself This patch adds _polymorphic_field and _polymorphic_map private methods to the Koha::File::Transports class to more clearly identify this as a polymorphic class base for TestBuilder. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #172 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186411&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #174 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186413&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #176 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186415&action=edit Bug 39190: Re-implement the connection testing We now use background jobs triggered by Transport->store to update the connection status. Status is now a json blob with more details, so we update the api definition to reflect that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #178 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186417&action=edit Bug 39190: Start of recording status updates from abort Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #180 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186419&action=edit Bug 39190: Remove test routine from API Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #182 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186421&action=edit Bug 39190: Redirect Schema to new classes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #184 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186423&action=edit Bug 39190: Add transport to test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #186 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186425&action=edit Bug 39190: Adjust schema to new structure Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #188 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186427&action=edit Bug 39190: Fix circular dependency causing C3 MRO failures Resolved circular dependency chain: Transport.pm → TestTransport.pm → Transports.pm → SFTP.pm → Transport.pm Changed 'use Koha::BackgroundJob::TestTransport' to runtime 'require' in the _post_store_trigger method to break the dependency cycle. This fixes the C3 method resolution order failures in Koha::File::Transport::FTP and Koha::File::Transport::SFTP. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #190 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186429&action=edit Bug 39190: Rename admin interface from sftp_servers to file_transports Renamed admin interface files and URLs to reflect the evolution from 'SFTP servers' to 'File transports' functionality: - admin/sftp_servers.pl -> admin/file_transports.pl - sftp_servers.tt -> file_transports.tt - Updated all URL references in templates and admin menu - Updated body id from admin_sftp_servers to admin_file_transports The functionality is now future-proof for the addition of new file transports, so the naming should reflect his broader scope. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #192 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186431&action=edit Bug 39190: Rename id => file_transport_id and remove mapping Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #197 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Can you please add some release notes? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 [Bug 38489] EDI should be updated to use the new FTP/SFTP Servers management page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33308 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308 [Bug 33308] Add ability to to use SFTP with runreport.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38629 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38629 [Bug 38629] Update sftp_file.pl to support the new SFTP configurations page -- You are receiving this mail because: You are watching all bug changes.