http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 43973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43973&action=edit Bug 15059 - Line break in html attribute In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet (same at OPAC) - perform a search on one word with a sort order (anything but relevance) - click on "Next" at the bottom of the page - look at link "Show more" in facets => Without patch the URL contains a lot of spaces => With patch the URL is correct - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 44106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44106&action=edit Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #5)

(In reply to Jonathan Druart from comment #3)

...

Please provide a fix on top of bug 14955

Super, Bug 14955 fixes the facets includes. This patch will only fix branchoverdues.tt

In this case, this bug can be tested without bug 14955. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44112|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44193&action=edit Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14955 Depends on|14955 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 [Bug 14955] "Show more" link contains double encoded characters -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.