[Bug 12540] New: Batch modifications for records - unavailable "Every" option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Bug ID: 12540 Summary: Batch modifications for records - unavailable "Every" option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Paola found the following error on testing bug 11395 comment 33: ERROR on MARC modification templates: unavailable "Every" option: I've edited this action: Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / Then I've changed all the 650-s into 750-s. I see "All" becoming "Every" (I have not understood why it has happened). I've saved, and I've editing the action again: now "All" is shown. I've not been able to set "Every" option. I think that showing "Every" is an error, or there's a lack in managing that option (see C) below). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11395 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Depends on|11395 | --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Removing the dependency for now. There is still no code here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42767&action=edit Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- I'm ok with the patch. Now i have "every" if i had "every" before saving. But what is the point of changing this choice ? Especially as we change only the label, not the value of the option. So it would not change anything in the modification process ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's just a wording improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42767|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 44200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44200&action=edit [SIGNED-OFF] Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44200|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44580&action=edit [PASSED QA] Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org