[Bug 24860] New: Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Bug ID: 24860 Summary: Add ability to place volume level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100644&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100645&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100646&action=edit Bug 24860: Add new syspref EnableVolumeHolds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100647&action=edit Bug 24860: Implement reserves.volume_id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100648&action=edit Bug 24860: Add ability to select a volume when placing a hold TODO: Add 'Volume' column to holds table on circulation.pl and moremember.pl Requires embedding volume in hold API -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100649&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100650&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100651&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100644|0 |1 is obsolete| | Attachment #100645|0 |1 is obsolete| | Attachment #100646|0 |1 is obsolete| | Attachment #100647|0 |1 is obsolete| | Attachment #100648|0 |1 is obsolete| | Attachment #100649|0 |1 is obsolete| | Attachment #100650|0 |1 is obsolete| | Attachment #100651|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101744&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101745&action=edit Bug 24860: Add new syspref EnableVolumeHolds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101746&action=edit Bug 24860: Implement reserves.volume_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101747&action=edit Bug 24860: Add ability to select a volume when placing a hold TODO: Add 'Volume' column to holds table on circulation.pl and moremember.pl Requires embedding volume in hold API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101748&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101749&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101750&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101751&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101744|0 |1 is obsolete| | Attachment #101745|0 |1 is obsolete| | Attachment #101746|0 |1 is obsolete| | Attachment #101747|0 |1 is obsolete| | Attachment #101748|0 |1 is obsolete| | Attachment #101749|0 |1 is obsolete| | Attachment #101750|0 |1 is obsolete| | Attachment #101751|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101827&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101828&action=edit Bug 24860: Add new syspref EnableVolumeHolds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101829&action=edit Bug 24860: Implement reserves.volume_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101830&action=edit Bug 24860: Add ability to select a volume when placing a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101831&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101832&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101833&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101834&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101835&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Receiving an ISE: - find/create bib with 3 items - put item_1 and item_2 in volume - place hold on volume - check in item_3 - get error: Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 846 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101827|0 |1 is obsolete| | Attachment #101828|0 |1 is obsolete| | Attachment #101829|0 |1 is obsolete| | Attachment #101830|0 |1 is obsolete| | Attachment #101831|0 |1 is obsolete| | Attachment #101832|0 |1 is obsolete| | Attachment #101833|0 |1 is obsolete| | Attachment #101834|0 |1 is obsolete| | Attachment #101835|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102230&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102231&action=edit Bug 24860: Add new syspref EnableVolumeHolds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102232&action=edit Bug 24860: Implement reserves.volume_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102233&action=edit Bug 24860: Add ability to select a volume when placing a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102234&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102235&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102236&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102237&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102238&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102230|0 |1 is obsolete| | --- Comment #36 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102239&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102231|0 |1 is obsolete| | --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102240&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102232|0 |1 is obsolete| | --- Comment #38 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102241&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102233|0 |1 is obsolete| | --- Comment #39 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102242&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102234|0 |1 is obsolete| | --- Comment #40 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102243&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102235|0 |1 is obsolete| | --- Comment #41 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102244&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102236|0 |1 is obsolete| | --- Comment #42 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102245&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102237|0 |1 is obsolete| | --- Comment #43 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102246&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102238|0 |1 is obsolete| | --- Comment #44 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102247&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102239|0 |1 is obsolete| | Attachment #102240|0 |1 is obsolete| | Attachment #102241|0 |1 is obsolete| | Attachment #102242|0 |1 is obsolete| | Attachment #102243|0 |1 is obsolete| | Attachment #102244|0 |1 is obsolete| | Attachment #102245|0 |1 is obsolete| | Attachment #102246|0 |1 is obsolete| | Attachment #102247|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106589&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106590&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106591&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106592&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106593&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106594&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106595&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106596&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106597&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106589|0 |1 is obsolete| | --- Comment #54 from Hugo Agud <hagud@orex.es> --- Created attachment 106682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106682&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Hugo Agud (hagud@orex.es Current status: Signed Off Current depends: 24857 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106590|0 |1 is obsolete| | --- Comment #55 from Hugo Agud <hagud@orex.es> --- Created attachment 106683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106683&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106591|0 |1 is obsolete| | --- Comment #56 from Hugo Agud <hagud@orex.es> --- Created attachment 106684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106684&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106592|0 |1 is obsolete| | --- Comment #57 from Hugo Agud <hagud@orex.es> --- Created attachment 106685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106685&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106593|0 |1 is obsolete| | --- Comment #58 from Hugo Agud <hagud@orex.es> --- Created attachment 106686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106686&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106594|0 |1 is obsolete| | --- Comment #59 from Hugo Agud <hagud@orex.es> --- Created attachment 106687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106687&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106595|0 |1 is obsolete| | --- Comment #60 from Hugo Agud <hagud@orex.es> --- Created attachment 106688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106688&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106596|0 |1 is obsolete| | --- Comment #61 from Hugo Agud <hagud@orex.es> --- Created attachment 106689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106689&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106597|0 |1 is obsolete| | --- Comment #62 from Hugo Agud <hagud@orex.es> --- Created attachment 106690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106690&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #63 from Hugo Agud <hagud@orex.es> --- I have already signed this patch, the patch does what it promises, but I wish to share some doubts. When you talk about volume, you're talking about Bindings items? We only can add a volume to an intem if the items is not created, there is no way of assign volumes to already created items? Volume is shown in a new colum, but in fact the value is also copied in enumchrom, that it can manage this and other values what happens if there is already another value at enumchrom? At opac-detail at staff we are seeing twice de value (Volume and enumchrom), however at edit items page, we are not seeing volume column, just enumchron that it can be modified by a librarian without any problem. There is no info on volume on opac-detail.tt page, then the user can't know there is a volume, although it can place a hold at volume level, without knowing anything kindest regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106682|0 |1 is obsolete| | --- Comment #64 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106742&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106683|0 |1 is obsolete| | --- Comment #65 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106743&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106684|0 |1 is obsolete| | --- Comment #66 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106744&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106685|0 |1 is obsolete| | --- Comment #67 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106745&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106686|0 |1 is obsolete| | --- Comment #68 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106746&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106687|0 |1 is obsolete| | --- Comment #69 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106747&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106688|0 |1 is obsolete| | --- Comment #70 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106748&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106689|0 |1 is obsolete| | --- Comment #71 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106749&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106690|0 |1 is obsolete| | --- Comment #72 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106750&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] Signed-off-by: Your Full Name <your_email> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Currently blocked by depending bug 24857 not applying. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106742|0 |1 is obsolete| | Attachment #106743|0 |1 is obsolete| | Attachment #106744|0 |1 is obsolete| | Attachment #106745|0 |1 is obsolete| | Attachment #106746|0 |1 is obsolete| | Attachment #106747|0 |1 is obsolete| | Attachment #106748|0 |1 is obsolete| | Attachment #106749|0 |1 is obsolete| | Attachment #106750|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108458&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108459&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108460&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108461&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108462&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #79 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108463&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108464&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108465&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108466&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108458|0 |1 is obsolete| | Attachment #108459|0 |1 is obsolete| | Attachment #108460|0 |1 is obsolete| | Attachment #108461|0 |1 is obsolete| | Attachment #108462|0 |1 is obsolete| | Attachment #108463|0 |1 is obsolete| | Attachment #108464|0 |1 is obsolete| | Attachment #108465|0 |1 is obsolete| | Attachment #108466|0 |1 is obsolete| | --- Comment #83 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109097&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109098&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109099&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109100&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109101&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109102&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109103&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109104&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109105&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109097|0 |1 is obsolete| | Attachment #109098|0 |1 is obsolete| | Attachment #109099|0 |1 is obsolete| | Attachment #109100|0 |1 is obsolete| | Attachment #109101|0 |1 is obsolete| | Attachment #109102|0 |1 is obsolete| | Attachment #109103|0 |1 is obsolete| | Attachment #109104|0 |1 is obsolete| | Attachment #109105|0 |1 is obsolete| | --- Comment #92 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109171&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109172&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109173&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109174&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109175&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109176&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109177&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #99 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109178&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109179&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109171|0 |1 is obsolete| | Attachment #109172|0 |1 is obsolete| | Attachment #109173|0 |1 is obsolete| | Attachment #109174|0 |1 is obsolete| | Attachment #109175|0 |1 is obsolete| | Attachment #109176|0 |1 is obsolete| | Attachment #109177|0 |1 is obsolete| | Attachment #109178|0 |1 is obsolete| | Attachment #109179|0 |1 is obsolete| | --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113616&action=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113617&action=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113618&action=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113619&action=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113620&action=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113621&action=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113622&action=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #108 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113623&action=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113624&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20447 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #110 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24860: Add reserves.volume_id error: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/volumes.perl). error: could not build fake ancestor Patch failed at 0001 Bug 24860: Add reserves.volume_id The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to place volume |Add ability to place item |level holds |group level holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113616|0 |1 is obsolete| | Attachment #113617|0 |1 is obsolete| | Attachment #113618|0 |1 is obsolete| | Attachment #113619|0 |1 is obsolete| | Attachment #113620|0 |1 is obsolete| | Attachment #113621|0 |1 is obsolete| | Attachment #113622|0 |1 is obsolete| | Attachment #113623|0 |1 is obsolete| | Attachment #113624|0 |1 is obsolete| | --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135922&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #112 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135923&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135924&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #114 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135925&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135926&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #116 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135927&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #117 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135928&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #118 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135929&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #119 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135930&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Kyle.. I'm not seeing tests added or adopted for the C4 module changes.. could you add these please? Failing QA for now... but this is close :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've been playing with this a little whilst continuing QA. Should there be a way from the OPAC to see what items are in a group when placing a group hold. I suppose, the main thoughts behind this is 'the patron doesn't need to know' and that the group name should be descriptive enough for them to make an informed choice at hold time?.. or maybe I've missed a bug where exposing the groups more on the OPAC is done? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135922|0 |1 is obsolete| | Attachment #135923|0 |1 is obsolete| | Attachment #135924|0 |1 is obsolete| | Attachment #135925|0 |1 is obsolete| | Attachment #135926|0 |1 is obsolete| | Attachment #135927|0 |1 is obsolete| | Attachment #135928|0 |1 is obsolete| | Attachment #135929|0 |1 is obsolete| | Attachment #135930|0 |1 is obsolete| | --- Comment #122 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138221&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138222&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #124 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138224&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #125 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138225&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #126 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138226&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #127 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138227&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #128 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138228&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #129 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138229&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #130 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138230&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #131 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #121)
I've been playing with this a little whilst continuing QA. Should there be a way from the OPAC to see what items are in a group when placing a group hold. I suppose, the main thoughts behind this is 'the patron doesn't need to know' and that the group name should be descriptive enough for them to make an informed choice at hold time?.. or maybe I've missed a bug where exposing the groups more on the OPAC is done?
You've got it. This is being used in production by one of our partners, and everything is centered around the item group description. Since items in a group are supposed to be identical, knowing which items are in a group does not provide any benefit outside the group name itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #132 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #120)
Sorry Kyle.. I'm not seeing tests added or adopted for the C4 module changes.. could you add these please?
Failing QA for now... but this is close :)
I've not seeing what module is missing tests. I've added tests for AddReserve already! Is there one I missed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Bug 24860 depends on bug 24857, which changed state. Bug 24857 Summary: Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #133 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Unit tests
I've not seeing what module is missing tests. I've added tests for AddReserve already! Is there one I missed?
Doing some code review and... there are some more *hides* Maybe discuss with Martin which ones should be included in tests: * C4/HoldsQueue.pm * GetHoldsQueueItems * GetPendingHoldRequestsForBib * MapItemsToHoldRequests C4/Reserves.pm * AddReserve (covered) * CheckReserves * _Findgroupreserve Koha/Hold.pm * item_group * forced_hold_level Koha/REST/V1/Holds.pm * add 2) Fixes some smaller stuff in 2 follow-ups, please have a look! 3) Holds to pull is off First my test case: * Added 9 items to a record, 3 each for vol. 1-3 in enumchron * Grouped them into 3 item groups * In the OPAC, I placed a hold onto the volume 2 group In /circ/pendingreserves.pl it shows wrong information: * 39999000005776 or any available. * Available enumchron: vol. 1, vol. 2, vol. 3 * There is no information that only volume 2 is wanted. 4) Holds queue Explodes: C4::HoldsQueue::GetHoldsQueueItems(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'item_group_items.item_group_id' in 'on clause' at /kohadevbox/koha/circ/view_holdsqueue.pl line 51 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 I've run a dbic and a restart_all, but the problem remains. The column exists in my database: describe item_group_items; +---------------------+---------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------------+---------+------+-----+---------+----------------+ | item_group_items_id | int(11) | NO | PRI | NULL | auto_increment | | item_group_id | int(11) | NO | MUL | 0 | | | item_id | int(11) | NO | UNI | 0 | | +---------------------+---------+------+-----+---------+----------------+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #134 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141214&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #135 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141215&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138221|0 |1 is obsolete| | Attachment #138222|0 |1 is obsolete| | Attachment #138224|0 |1 is obsolete| | Attachment #138225|0 |1 is obsolete| | Attachment #138226|0 |1 is obsolete| | Attachment #138227|0 |1 is obsolete| | Attachment #138228|0 |1 is obsolete| | Attachment #138229|0 |1 is obsolete| | Attachment #138230|0 |1 is obsolete| | Attachment #141214|0 |1 is obsolete| | Attachment #141215|0 |1 is obsolete| | --- Comment #136 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141735&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #137 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141736&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #138 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141737&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #139 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141738&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #140 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141739&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #141 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141740&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #142 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141741&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #143 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141742&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #144 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141743&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #145 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141744&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #146 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141745&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #147 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141746&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #148 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141747&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #149 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141748&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141749&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #151 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141750&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #152 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #133)
1) Unit tests
I've added unit tests for everything you listed!
2) Fixes some smaller stuff in 2 follow-ups, please have a look!
Thank you!
3) Holds to pull is off
First my test case: * Added 9 items to a record, 3 each for vol. 1-3 in enumchron * Grouped them into 3 item groups * In the OPAC, I placed a hold onto the volume 2 group
In /circ/pendingreserves.pl it shows wrong information: * 39999000005776 or any available. * Available enumchron: vol. 1, vol. 2, vol. 3 * There is no information that only volume 2 is wanted.
I don't think Holds to pull is the tool a library should be using if they are using item group holds. This same is true for the holds itemtype filter, which has been in Koha since 16.05. I'm finding the holds to pull interface doesn't display data well. For instance, if I place one item level hold, and one biblio level hold for the same record, holds to pull doesn't really indicate that. If you can can tell me what you'd like to see, I'll see what I can do!
4) Holds queue
One line of the query got removed in a rebase. Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #153 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Having another look here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31832 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #154 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) All the new and old tests pass. But: I did a reset_all to have a clean starting page before applying these patches. And my branches are all mangled after running the tests: I end up with 36 branches on the sample database, a lot of those generated ones like: brW5iS. There are also a ton of generated patrons... I am not completely sure it's the new tests here, but could you please check your clean-up? 3) Holds queue is looking good now: a1 or any item from item_group A Just please remove the _ :) 2) Pending holds / Holds to pull
I don't think Holds to pull is the tool a library should be using if they are using item group holds. This same is true for the holds itemtype filter, which has been in Koha since 16.05. I'm finding the holds to pull interface doesn't display data well. For instance, if I place one item level hold, and one biblio level hold for the same record, holds to pull doesn't really indicate that. If you can can tell me what you'd like to see, I'll see what I can do!
I don't think we can argue that, unless we hid the report once the item group holds are activated... and that might create quite some complaints. I know single branch libraries like to use the report, also the less busy ones. Maybe it would be worth adding a note to the system preference? "Might not go well with..." or so? In general the page needs work, I agree with you on that! I did some more testing: a) If there is a record level hold only: Only 39999000011418 b) If there is an item level hold only: 39999000005097 or any available. c) If there is a group level hold only: 39999000005097 or any available. For a start, could we catch the third case and have a correct message display? Similar to the one on holds queue? I'd be ok with that as a solution for this patch set. For the future 2 ideas (just to get your opinion, will file later): * If there are different types of holds we could display this as a note: "Different types of holds, please check holds page"? * We could repeat the information for every hold, maybe deduplicated. At the moment it looks like we only get the info for the first hold placed. Maye something like: * Only 39999000011418 (1 hold) * 39999000005097 or any available (2 holds) To summarize: * Verify/make sure tests clean up their created data * Remove _ from message on holds queue page * Adapt message when only a item group hold exists on holds to pull OK? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141735|0 |1 is obsolete| | Attachment #141736|0 |1 is obsolete| | Attachment #141737|0 |1 is obsolete| | Attachment #141738|0 |1 is obsolete| | Attachment #141739|0 |1 is obsolete| | Attachment #141740|0 |1 is obsolete| | Attachment #141741|0 |1 is obsolete| | Attachment #141742|0 |1 is obsolete| | Attachment #141743|0 |1 is obsolete| | Attachment #141744|0 |1 is obsolete| | Attachment #141745|0 |1 is obsolete| | Attachment #141746|0 |1 is obsolete| | Attachment #141747|0 |1 is obsolete| | Attachment #141748|0 |1 is obsolete| | Attachment #141749|0 |1 is obsolete| | Attachment #141750|0 |1 is obsolete| | --- Comment #155 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142413&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #156 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142414&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #157 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142415&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142416&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #159 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142417&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #160 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142418&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #161 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142419&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #162 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142420&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #163 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142421&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #164 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142422&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #165 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142423&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #166 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142424&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #167 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142425&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #168 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142426&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #169 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142427&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #170 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142428&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #171 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142429&action=edit Bug 24860: (QA follow-up) Fix typo in holds queue viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #172 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142430&action=edit Bug 24860: (QA follow-up) Show group holds on Holds to pull -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #173 from Kyle M Hall <kyle@bywatersolutions.com> ---
To summarize: * Verify/make sure tests clean up their created data
Fixed on Bug 31920
* Remove _ from message on holds queue page
Fixed with followup!
* Adapt message when only a item group hold exists on holds to pull
Also fixed with a followup! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #174 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #175 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Kyle, I tried to understand what's going wrong here, but failed: When opening 'Holds to pull': Can't call method "id" on an undefined value at /kohadevbox/koha/circ/pendingreserves.pl line 288 287: if ( $res_info->item_group ) { 288: $hold_info->{barcodes} = [ uniq map { defined $_->barcode && $_->item_group->id == $res_info->item_group_id ? $_->barcode : () } @$items ]; 289: } If you can fix quickly, I'll retest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #176 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #175)
Sorry Kyle, I tried to understand what's going wrong here, but failed:
When opening 'Holds to pull':
Can't call method "id" on an undefined value at /kohadevbox/koha/circ/pendingreserves.pl line 288
287: if ( $res_info->item_group ) { 288: $hold_info->{barcodes} = [ uniq map { defined $_->barcode && $_->item_group->id == $res_info->item_group_id ? $_->barcode : () } @$items ]; 289: }
If you can fix quickly, I'll retest.
*ping*? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #177 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142827&action=edit Bug 24860: (QA follow-up): Don't assume item group is set for all items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #178 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back here again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #179 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry Kyle, the latest follow-up fixed the error, but the new text in pendingreserves never displays. I have tried to figure out what's going on there, but got stuck on this line: + if ( $res_info->item_group ) { + $hold_info->{barcodes} = [ uniq map { defined $_->barcode && $_->item_group && ( $_->item_group->id == $res_info->item_group_id ) ? $_->barcode : () } @$items ]; + } + I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold group hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142413|0 |1 is obsolete| | Attachment #142414|0 |1 is obsolete| | Attachment #142415|0 |1 is obsolete| | Attachment #142416|0 |1 is obsolete| | Attachment #142417|0 |1 is obsolete| | Attachment #142418|0 |1 is obsolete| | Attachment #142419|0 |1 is obsolete| | Attachment #142420|0 |1 is obsolete| | Attachment #142421|0 |1 is obsolete| | Attachment #142422|0 |1 is obsolete| | Attachment #142423|0 |1 is obsolete| | Attachment #142424|0 |1 is obsolete| | Attachment #142425|0 |1 is obsolete| | Attachment #142426|0 |1 is obsolete| | Attachment #142427|0 |1 is obsolete| | Attachment #142428|0 |1 is obsolete| | Attachment #142429|0 |1 is obsolete| | Attachment #142430|0 |1 is obsolete| | Attachment #142827|0 |1 is obsolete| | --- Comment #180 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142955&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #181 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142956&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #182 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142957&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #183 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142958&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #184 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142959&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #185 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142960&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #186 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142961&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #187 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142962&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #188 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142963&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #189 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142964&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #190 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142965&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #191 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142966&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #192 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142967&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #193 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142968&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #194 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142969&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #195 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142970&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #196 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142971&action=edit Bug 24860: (QA follow-up) Fix typo in holds queue viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #197 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142972&action=edit Bug 24860: (QA follow-up) Show group holds on Holds to pull -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #198 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142973&action=edit Bug 24860: (QA follow-up): Don't assume item group is set for all items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #199 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142974&action=edit Bug 24860: (QA follow-up) Ask for any available item of matching group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #200 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142975&action=edit Bug 24860: (QA follow-up) Don't show holds where a matching item group item is not available -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #201 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #179)
I am sorry Kyle, the latest follow-up fixed the error, but the new text in pendingreserves never displays. I have tried to figure out what's going on there, but got stuck on this line:
+ if ( $res_info->item_group ) { + $hold_info->{barcodes} = [ uniq map { defined $_->barcode && $_->item_group && ( $_->item_group->id == $res_info->item_group_id ) ? $_->barcode : () } @$items ]; + } +
I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold group hold.
Yes, the problem here is that there are not items with the selected hold group currently available. We have two choices where, either we hide that hold until there is an item from that item group available, or we just display an "Any item from item group $item_group" message. "Bug 24860: (QA follow-up) Don't show holds where a matching item group item is not available" does the former, "Bug 24860: (QA follow-up) Ask for any available item of matching group" does the latter. Please choose which behavior you would prefer and deprecate the other patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #202 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #201)
(In reply to Katrin Fischer from comment #179)
I am sorry Kyle, the latest follow-up fixed the error, but the new text in pendingreserves never displays. I have tried to figure out what's going on there, but got stuck on this line:
+ if ( $res_info->item_group ) { + $hold_info->{barcodes} = [ uniq map { defined $_->barcode && $_->item_group && ( $_->item_group->id == $res_info->item_group_id ) ? $_->barcode : () } @$items ]; + } +
I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold group hold.
Yes, the problem here is that there are not items with the selected hold group currently available. We have two choices where, either we hide that hold until there is an item from that item group available, or we just display an "Any item from item group $item_group" message.
"Bug 24860: (QA follow-up) Don't show holds where a matching item group item is not available" does the former, "Bug 24860: (QA follow-up) Ask for any available item of matching group" does the latter. Please choose which behavior you would prefer and deprecate the other patch!
But it's not true... in my test case I had 2 available items within this group. I can retest, but I am pretty sure. I had created new items in order to group and place a hold on them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142974|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #203 from Kyle M Hall <kyle@bywatersolutions.com> --- Ah! I was testing a slightly different scenario. You are right, the last patch is no good. I've obsoleted it and now everything should be good! I'm not sure what scenario you are
But it's not true... in my test case I had 2 available items within this group. I can retest, but I am pretty sure. I had created new items in order to group and place a hold on them.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142955|0 |1 is obsolete| | --- Comment #204 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142992&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142956|0 |1 is obsolete| | --- Comment #205 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142993&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142957|0 |1 is obsolete| | --- Comment #206 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142994&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142958|0 |1 is obsolete| | --- Comment #207 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142995&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142959|0 |1 is obsolete| | --- Comment #208 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142996&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142960|0 |1 is obsolete| | --- Comment #209 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142997&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142961|0 |1 is obsolete| | --- Comment #210 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142998&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142962|0 |1 is obsolete| | --- Comment #211 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142999&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142963|0 |1 is obsolete| | --- Comment #212 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143000&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142964|0 |1 is obsolete| | --- Comment #213 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143001&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142965|0 |1 is obsolete| | --- Comment #214 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143002&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142966|0 |1 is obsolete| | --- Comment #215 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143003&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142967|0 |1 is obsolete| | --- Comment #216 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143004&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142968|0 |1 is obsolete| | --- Comment #217 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143005&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142969|0 |1 is obsolete| | --- Comment #218 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143006&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142970|0 |1 is obsolete| | --- Comment #219 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143007&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142971|0 |1 is obsolete| | --- Comment #220 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143008&action=edit Bug 24860: (QA follow-up) Fix typo in holds queue viewer Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142972|0 |1 is obsolete| | --- Comment #221 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143009&action=edit Bug 24860: (QA follow-up) Show group holds on Holds to pull Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142973|0 |1 is obsolete| | --- Comment #222 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143010&action=edit Bug 24860: (QA follow-up): Don't assume item group is set for all items Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142974|0 |1 is obsolete| | --- Comment #223 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143011&action=edit Bug 24860: (QA follow-up) Ask for any available item of matching group Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #224 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this feature you can release notes| |now place holds on groups | |of items. A group consists | |of multiple items of the | |same record, representing | |for example, all items of a | |specific volume. When a | |hold for an item group is | |placed, only items of the | |requested group will be | |able to fill the hold. | |The | |feature is enabled using | |the new | |EnableItemGroupHolds system | |preference. It also | |requires EnableItemGroups | |for managing item groups. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #225 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- `biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic record the group belongs to', DEFAULT 0, is this correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/609 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|With this feature you can |This feature was sponsored release notes|now place holds on groups |by Arlington Public |of items. A group consists |Library. With this feature |of multiple items of the |you can now place holds on |same record, representing |groups of items. A group |for example, all items of a |consists of multiple items |specific volume. When a |of the same record, |hold for an item group is |representing for example, |placed, only items of the |all items of a specific |requested group will be |volume. When a hold for an |able to fill the hold. |item group is placed, only |The |items of the requested |feature is enabled using |group will be able to fill |the new |the hold. |EnableItemGroupHolds system |The feature is |preference. It also |enabled using the new |requires EnableItemGroups |EnableItemGroupHolds system |for managing item groups. |preference. It also | |requires EnableItemGroups | |for managing item groups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #226 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think we are missing from_local_hold_group in reserve/request.tt 1581 switch (override_items[itemnumber].holdallowed) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #227 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #225)
`biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic record the group belongs to',
DEFAULT 0, is this correct?
As 0 cannot be used, it's harmless but you are correct and we should update the table schema. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #228 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #227)
(In reply to Jonathan Druart from comment #225)
`biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic record the group belongs to',
DEFAULT 0, is this correct?
As 0 cannot be used, it's harmless but you are correct and we should update the table schema.
Out of scope for this bug, but the recalls table has the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #229 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #228)
(In reply to Kyle M Hall from comment #227)
(In reply to Jonathan Druart from comment #225)
`biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic record the group belongs to',
DEFAULT 0, is this correct?
As 0 cannot be used, it's harmless but you are correct and we should update the table schema.
Out of scope for this bug, but the recalls table has the same issue.
Bug 33053 - Tables item_groups and recalls have a biblio_id column with a default of 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #230 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #226)
I think we are missing from_local_hold_group in reserve/request.tt
1581 switch (override_items[itemnumber].holdallowed) {
Bug 33052 - Add a message for from_local_hold_group override -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34155 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 [Bug 34155] OPAC item level holds "force" option broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #231 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- See bug 34155, OPAC item level holds="force" is broken in opac-reserve.pl: 495 $biblioLoopIter{force_hold} = 1 if $opac_hold_policy eq 'F'; But we are ignoring this with the change in "24860: Add ability to select an item group when placing a hold - OPAC" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 [Bug 34520] Database update 22.06.00.078 breaks update process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34666 [Bug 34666] _Findgroupreserve is not returning title level matches from the queue for holds with no item group -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org