https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152536&action=edit Bug 34085: Remove the use of event attributes from basket groups template This patch removes the use of event attributes (onclick, onsubmit) from the basket groups template. These events are defined now along with the other in-page JS. This change allows us to move the scripts to the bottom of the page. Unrelated changes: There was no confirmation tied to the process of deleting a basket group. I've added one. And there were several "MSG_" variables defined which were unused and have been removed. To test you should have at least one vendor with at least one basket group. - Apply the patch and go to Acquisitions. - Locate a vendor with an associated basket group. - Edit a basketgroup - Confirm that editing works correctly (leaving "Close basket group" unchecked") - Confirm that editing works correctly with "Close basket group" checked. - In the list of closed basket groups, confirm that all the controls work correctly. - Create an empty basket group and confirm that clicking the associated "Delete" button in the list of basket groups triggers a confirmation, "Are you sure you want to delete this basket group?" Test that both confirming and cancelling work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152536|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 154726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154726&action=edit Bug 34085: Remove the use of event attributes from basket groups template This patch removes the use of event attributes (onclick, onsubmit) from the basket groups template. These events are defined now along with the other in-page JS. This change allows us to move the scripts to the bottom of the page. Unrelated changes: There was no confirmation tied to the process of deleting a basket group. I've added one. And there were several "MSG_" variables defined which were unused and have been removed. To test you should have at least one vendor with at least one basket group. - Apply the patch and go to Acquisitions. - Locate a vendor with an associated basket group. - Edit a basketgroup - Confirm that editing works correctly (leaving "Close basket group" unchecked") - Confirm that editing works correctly with "Close basket group" checked. - In the list of closed basket groups, confirm that all the controls work correctly. - Create an empty basket group and confirm that clicking the associated "Delete" button in the list of basket groups triggers a confirmation, "Are you sure you want to delete this basket group?" Test that both confirming and cancelling work correctly. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154726|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155399&action=edit Bug 34085: Remove the use of event attributes from basket groups template This patch removes the use of event attributes (onclick, onsubmit) from the basket groups template. These events are defined now along with the other in-page JS. This change allows us to move the scripts to the bottom of the page. Unrelated changes: There was no confirmation tied to the process of deleting a basket group. I've added one. And there were several "MSG_" variables defined which were unused and have been removed. To test you should have at least one vendor with at least one basket group. - Apply the patch and go to Acquisitions. - Locate a vendor with an associated basket group. - Edit a basketgroup - Confirm that editing works correctly (leaving "Close basket group" unchecked") - Confirm that editing works correctly with "Close basket group" checked. - In the list of closed basket groups, confirm that all the controls work correctly. - Create an empty basket group and confirm that clicking the associated "Delete" button in the list of basket groups triggers a confirmation, "Are you sure you want to delete this basket group?" Test that both confirming and cancelling work correctly. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #5)

Created attachment 155400 [details] [review] Bug 34085: [follow-up] remove typo in Javascript

^^ please run the QA script! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.