[Bug 42651] New: When CatalogConcerns is enabled the concern table is not loaded on detail.pl and a Uncaught TypeError is thrown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Bug ID: 42651 Summary: When CatalogConcerns is enabled the concern table is not loaded on detail.pl and a Uncaught TypeError is thrown Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl to create the error: - enable system pref CatalogConcerns - open dev tools -> console - open a biblio f.e. cgi-bin/koha/catalogue/detail.pl?biblionumber=268 - Firefox says: Uncaught TypeError: can't access property "unique", r[o][t] is undefined - check the concern table is not loaded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42283 [Bug 42283] Tidy all script tags - cataloguing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Jan Kissig <bibliothek@th-wildau.de> --- okay found the reason: table_settings was set twice on detail.tt once in when Koha.Preference('AcquisitionDetails') enabled and once when Koha.Preference('CatalogConcerns') Going to fix that in 42283 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This effects 26.05 and Bug 42283 is not backport-able. So I am re-opening this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com Status|REOPENED |Needs Signoff --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Tested on 26.05 and confirmed that the JavaScript error no longer occurs, the Concerns table loads correctly, and both tables function as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 208742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208742&action=edit Bug 42651: Fix Catalog Concerns table initialization To test: 1. Enable the CatalogConcerns and AcquisitionDetails system preferences. 2. Open a bibliographic record in the staff interface. 3. Open the browser developer console. 4. Confirm a JavaScript error occurs and the Concerns table does not load. 5. Apply the patch. 6. Refresh the bibliographic record. 7. Confirm the JavaScript error no longer occurs. 8. Confirm the Concerns table loads correctly. 9. Verify the Hide resolved and Show all controls work. 10. Confirm the Acquisition Details table still works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Fixes a JavaScript error release notes| |that prevented the Catalog | |Concerns table from loading | |on bibliographic detail | |pages when Acquisition | |Details was enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 208778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208778&action=edit Bug 42651: Fix Catalog Concerns table initialization To test: 1. Enable the CatalogConcerns and AcquisitionDetails system preferences. 2. Open a bibliographic record in the staff interface. 3. Open the browser developer console. 4. Confirm a JavaScript error occurs and the Concerns table does not load. 5. Apply the patch. 6. Refresh the bibliographic record. 7. Confirm the JavaScript error no longer occurs. 8. Confirm the Concerns table loads correctly. 9. Verify the Hide resolved and Show all controls work. 10. Confirm the Acquisition Details table still works. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I could not reproduce on main, but could produce on 26.05.x. Does the Version field need to be updated? Testing notes (using KTD): 1. Start up a KTD instance that uses 26.05.x. 2. Add some catalog concerns to a record, so that you can reproduce the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #7 from David Nind <david@davidnind.com> --- I changed the importance from an enhancement to a normal bug, as it is an error/something not working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 --- Comment #8 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 208912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208912&action=edit Bug 42651: Fix Catalog Concerns table initialization To test: 1. Enable the CatalogConcerns and AcquisitionDetails system preferences. 2. Open a bibliographic record in the staff interface. 3. Open the browser developer console. 4. Confirm a JavaScript error occurs and the Concerns table does not load. 5. Apply the patch. 6. Refresh the bibliographic record. 7. Confirm the JavaScript error no longer occurs. 8. Confirm the Concerns table loads correctly. 9. Verify the Hide resolved and Show all controls work. 10. Confirm the Acquisition Details table still works. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42282 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- This patch works as described and is for 26.05. only. In main this is fixed via https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 which will not be backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #10 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Great to see this has passed QA and is a candidate for backport. We will be happy to see when it's determined which version of 26.05.x it will be in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42651 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.06 released in| | Status|Passed QA |Pushed to stable --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 26.05.x for upcoming 26.05.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org