[Bug 10829] New: Browse across pages breaks for authority searches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Bug ID: 10829 Summary: Browse across pages breaks for authority searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org OK.. this one was hard to replicate, even harder to trace/debug, but relatively simple to fix! Test plan 1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results) 2. Click the final result on any page of results (there must be more results to follow for this to work) 3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page. 4. It should take you to the next result in the search list (i.e the first result from the next page of results) Double check it is correct, we found that it was often not. 5. Apply patch and run same process, this time you should get the correct paging. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 20803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20803&action=edit Bug 10829 - Browse across pages breaks for authority searches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr@software.coop --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 7898 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #3 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21965&action=edit Bug 10829 - Browse across pages breaks for authority searches Test plan 1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results) 2. Click the final result on any page of results (there must be more results to follow for this to work) 3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page. 4. It should take you to the next result in the search list (i.e the first result from the next page of results) - Double check it is correct, we found that it was often not. 5. Apply patch and run same process, this time you should get the correct paging. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21965|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22314&action=edit Bug 10829 - Browse across pages breaks for authority searches Test plan 1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results) 2. Click the final result on any page of results (there must be more results to follow for this to work) 3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page. 4. It should take you to the next result in the search list (i.e the first result from the next page of results) - Double check it is correct, we found that it was often not. 5. Apply patch and run same process, this time you should get the correct paging. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I reproduce the issue and I confirm this patch fixes it! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Good catch. Pushed to master; thanks, Martin! Also, this is an object lesson in the utility of named parameters. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org