[Bug 9192] New: UNIMARC_sync_date_created_with_marc_biblio.pl field creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Bug ID: 9192 Summary: UNIMARC_sync_date_created_with_marc_biblio.pl field creation Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com in UNIMARC_sync_date_created_with_marc_biblio.pl, if field does not exist, it is created. This creation must be different if it is a control field or not. See http://search.cpan.org/~gmcharlt/MARC-Record-2.0.3/lib/MARC/Field.pm#new%28%... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13840&action=edit Proposed patch I field does not exits, create a new one with subfield (or value for a control field). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8844 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- 8844 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14281&action=edit Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14281|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 14939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14939&action=edit Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
Created attachment 14939 [details] Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Mason James <mtj@kohaaloha.com>
testing 1 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp var') passing QA.. patch looks good -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- There is a problem with this patch. This patch does not check whether the specified field is a control field or variable field. Instead, to decide which field creation routine to call it checks whether the user has supplied a subfield marker. Please provide a follow-up that either identifies control fields based on the fixed fields defined in the UNIMARC standard (field number < 010, I think) or by using the is_controlfield_tag routine from MARC::Record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15327&action=edit Proposed patch (follow-up 1) Follow up to test control fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Is this what you meant Jared ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- What must be done to continue ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15327|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20866&action=edit [SIGNED-OFF] Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation (followup) Add tests : if field < 10 it must not have a subfield if field > 9 is must have a subfield Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both patches applied, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20867&action=edit Bug 9192: followup fix typo Fix typo on usage message. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can I please get a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #13 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Test plan : - Launch UNIMARC_sync_date_created_with_marc_biblio.pl : - with -c 512 => Script dies with message : "date-created-marc field is greated that 009, it should have a subfield." - with -c 006a => Script dies with message : "die "date-created-marc field is lower that 010, it should not have a subfield." - with -m 512 => Script dies with message : "date-modified-marc field is greated that 009, it should have a subfield." - with -m 006a => Script dies with message : "die "date-modified-marc field is lower that 010, it should not have a subfield." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- QA Comment : * UNIMARC specific * no visible side effect, maintenance script * passes koha-qa.pl * tested by a French & an Argentina librarian, 2 different UNIMARC libraries passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14939|0 |1 is obsolete| | Attachment #20866|0 |1 is obsolete| | Attachment #20867|0 |1 is obsolete| | --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22173&action=edit [PASSED QA]Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Mason James <mtj@kohaaloha.com> Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation (followup) Add tests : if field < 10 it must not have a subfield if field > 9 is must have a subfield Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both patches applied, no koha-qa errors. Bug 9192: followup fix typo Fix typo on usage message. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #16 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- It is strange to have a cronjob for doing that in UNIMARC. Do you know how it is done in MARC21? If it is a better way, maybe we could do a ENH for making unimarc behave the same way as MARC21? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to mathieu saby from comment #16)
It is strange to have a cronjob for doing that in UNIMARC. Do you know how it is done in MARC21? If it is a better way, maybe we could do a ENH for making unimarc behave the same way as MARC21?
MARC21 users tend to use the 005 field, which per bug 5374 gets updated automatically whenever a bib is saved (it does that for UNIMARC as well, actually).
From my POV, it would be a plausible enhancement to have the UNIMARC date add/modified fields be updated by ModBiblio(Marc). Is that plausible from the POV of UNIMARC users?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- I've pushed the current patch to master, BTW. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #19 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Galen Charlton from comment #18)
I've pushed the current patch to master, BTW. Thanks, Fridolyn!
(In reply to Galen Charlton from comment #17)
(In reply to mathieu saby from comment #16)
It is strange to have a cronjob for doing that in UNIMARC. Do you know how it is done in MARC21? If it is a better way, maybe we could do a ENH for making unimarc behave the same way as MARC21?
MARC21 users tend to use the 005 field, which per bug 5374 gets updated automatically whenever a bib is saved (it does that for UNIMARC as well, actually).
From my POV, it would be a plausible enhancement to have the UNIMARC date add/modified fields be updated by ModBiblio(Marc). Is that plausible from the POV of UNIMARC users?
005 could probably be used in unimarc, as it is made for that ;-) We tested a long time ago, but I think I remember that the plugin was just updating 005 when some value was already in 005, and not filling it at first when we create the record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #20 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Galen Charlton from comment #18)
I've pushed the current patch to master, BTW. Thanks, Fridolyn!
Thanks a lot. I know that using this script with cron once a day and not when record is created/modified is to speed up those actions. It was even more usefull when items where in MARCXML. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org