[Bug 39787] New: Sending EDI order from basket fails if only one Library EAN exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Bug ID: 39787 Summary: Sending EDI order from basket fails if only one Library EAN exists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If there is only one EAN defined, the button has no pulldown. Clicking the button to send the edi order results in the error: No sender ean passed to order creation: basket = Koha::Schema::Result::Aqbasket=HASH(0x5574bf315b98)->basketno() -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |slavashishkin@gmail.com |ity.org | CC| |nugged@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 182036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182036&action=edit Bug 39787: Fix missing sender EAN when only one EAN is defined If only one EAN is defined for the library, the Create EDIFACT order button template used the eans.0 object instead of its ean field. As a result, the data-ean attribute contained an object, not the EAN string. Fixed by explicitly accessing the field: eans.0.ean. Steps to reproduce: 1. Ensure only one Library EAN is configured in /cgi-bin/koha/admin/edi_ean_accounts.pl. 2. Create a new basket. 3. Inspect the HTML of the Create EDIFACT order button. 4. The data-ean attribute will show an object instead of EAN string — e.g. Koha::Schema::Result... (this is the bug). 5. Apply the patch and reload the basket page. 6. Inspect the HTML again — data-ean should now show the EAN string (fixed). 7. Click the button, confirm basket closure, then go to EDIFACT messages (/cgi-bin/koha/acqui/edifactmsgs.pl) and verify the message was created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37993 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 [Bug 37993] Having a single EDI EAN account produces a bad redirect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182036|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 182067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182067&action=edit Bug 39787: Fix missing sender EAN when only one EAN is defined If only one EAN is defined for the library, the Create EDIFACT order button template used the eans.0 object instead of its ean field. As a result, the data-ean attribute contained an object, not the EAN string. Fixed by explicitly accessing the field: eans.0.ean. Steps to reproduce: 1. Ensure only one Library EAN is configured in /cgi-bin/koha/admin/edi_ean_accounts.pl. 2. Create a new basket. 3. Inspect the HTML of the Create EDIFACT order button. 4. The data-ean attribute will show an object instead of EAN string — e.g. Koha::Schema::Result... (this is the bug). 5. Apply the patch and reload the basket page. 6. Inspect the HTML again — data-ean should now show the EAN string (fixed). 7. Click the button, confirm basket closure, then go to EDIFACT messages (/cgi-bin/koha/acqui/edifactmsgs.pl) and verify the message was created. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Enable the EDIFACT system preference. 2. Create an EDI account for "My Vendor" (Koha administration > Acquisition parameters > EDI accounts). 3. Create a library EAN (Koha administration > Acquisition parameters > Library EANs). 4. Then the "Create EDIFACT order" button will appear on the basket page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182067|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182074&action=edit Bug 39787: Fix missing sender EAN when only one EAN is defined If only one EAN is defined for the library, the Create EDIFACT order button template used the eans.0 object instead of its ean field. As a result, the data-ean attribute contained an object, not the EAN string. Fixed by explicitly accessing the field: eans.0.ean. Steps to reproduce: 1. Ensure only one Library EAN is configured in /cgi-bin/koha/admin/edi_ean_accounts.pl. 2. Create a new basket. 3. Inspect the HTML of the Create EDIFACT order button. 4. The data-ean attribute will show an object instead of EAN string — e.g. Koha::Schema::Result... (this is the bug). 5. Apply the patch and reload the basket page. 6. Inspect the HTML again — data-ean should now show the EAN string (fixed). 7. Click the button, confirm basket closure, then go to EDIFACT messages (/cgi-bin/koha/acqui/edifactmsgs.pl) and verify the message was created. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37993 CC| |fridolin.somers@biblibre.co | |m Blocks|37993 | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah Bug 37993 is the cause of the bug so moving to "depends on" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 [Bug 37993] Having a single EDI EAN account produces a bad redirect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Patch complexity|--- |Trivial patch Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Bug 39787 depends on bug 37993, which changed state. Bug 37993 Summary: Having a single EDI EAN account produces a bad redirect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org