https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123863&action=edit Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Mmm this is changed since 20.11.00. We at Biblibre have fixed each broken customisation of OPAC. This is not the only change, and for me it makes sens to have an id instead of a class for a tag existing only once in the page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Lucas Gass from comment #3)

(In reply to Fridolin Somers from comment #2)

...

Mmm this is changed since 20.11.00. We at Biblibre have fixed each broken customisation of OPAC. This is not the only change, and for me it makes sens to have an id instead of a class for a tag existing only once in the page.

Why can't it have both?

It can, I'm not against it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described - thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123933|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123936&action=edit Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123936|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123960&action=edit Bug 28868: Add back mastheadsearch class name In masthead.inc there is a wrapper for the main search bar called #opac-main-search. Prior to Bug 20168 that warpper had a class name of 'mastheadsearch'. Historically CSS/JS customization of the main search bar was done via the mastheadsearch class. Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds back the release notes| |class 'mastheadsearch' | |which was lost during the | |upgrade to Bootstrap 4 in | |Bug 20168. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- I very much appreciate everyone's efforts on this one, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Bug 28868 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.