[Bug 20491] New: Use "Date due" in table header of item table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Bug ID: 20491 Summary: Use "Date due" in table header of item table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl On <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x there is a table of existing items. One of the columns is called "Checked out". I would assume this is the date the item was checked out, but it is in fact the due date (from items.onloan). It would be less confusing if this column was called "Date due" or something similar. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The description is pulled from the frameworks, probably never was changed after we switched the fields from being boolean to being a date. Not quite as easy of a fix as I hoped. We'd need to do a search and replace on all the frameworks still using this description for 952$q. Of course it also means that for now you can easily change it in your installations, but a global fix would be nicer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 --- Comment #2 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84098&action=edit Bug 20491: Test plan: 1) Go to admin, then to MARC frameworks, then to default frameworks structure, then subfield stucture for 952 2) Verify that 'q' is described as 'checked out' 3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 4) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 --- Comment #3 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84099&action=edit Bug 20491: Updating the MARC subfield desciption of 952q Test plan: 1) Go to admin, then to MARC frameworks, then to default frameworks structure, then subfield stucture for 952 2) Verify that 'q' is described as 'checked out' 3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 4) Verify that 'q' is also descirbed as 'Checked out' in 5) Apply patch and update your database 6) Verify that the description of 'q' has changed to 'Date due' 7) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 6) Verify that it has changed to 'Date due' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hickeyhe@wgc.school.nz |ity.org | CC| |hickeyhe@wgc.school.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84099|0 |1 is obsolete| | --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 84222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84222&action=edit Bug 20491: Updating the MARC subfield desciption of 952q Test plan: 1) Go to admin, then to MARC frameworks, then to default frameworks structure, then subfield stucture for 952 2) Verify that 'q' is described as 'checked out' 3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 4) Verify that 'q' is also descirbed as 'Checked out' in 5) Apply patch and update your database 6) Verify that the description of 'q' has changed to 'Date due' 7) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 6) Verify that it has changed to 'Date due' Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- I figured your first patch was not neccessary, so I put the tag obsolete on it and only tested the second one, it seems to work correctly. It's signed off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84098|Bug 20491: Test plan: 1) Go |Bug 20491: Test plan: 1) Go description|to admin, then to MARC |to admin, then to MARC |frameworks, then to default |frameworks, then to default |frameworks structure, then |frameworks structure, then |subfield stucture for 952 |subfield stucture for 952 |2) Verify that 'q' is |2) Verify that 'q' is |described as 'checked out' |described as 'checked out' |3) Go to |3) Go to |<intranet>/cgi-bin/koha/cat |<intranet>/cgi-bin/koha/cat |aloguing/additem.pl?biblion |aloguing/additem.pl?biblion |umber=x 4) |umber=x 4) Attachment #84098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I was testing but didn't notice that it was already signed-off! For the frameworks: I can confirm that this works as intended after the patch is applied. For NEW items checked out: I can confirm that this works as intended for NEW items checked out after the patch is applied. That is, the column heading displays as 'Due date'. For EXISTING items already checked out: It doesn't seem to work for EXISTING items checked out before the patch is applied. That is, the column heading stays as 'Checked out'. - Is something required in the database update to update all existing checked out items? - Is it something to do with caching? I restarted all services (using koha-testing-docker = restart_all), rebuilt the index (koha-rebuild-zebra -f -v kohadev), and used a browser with all the history completely cleared. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 --- Comment #7 from David Nind <david@davidnind.com> --- Also, a couple of things I noted that are probably obvious to those more familiar with Koha and testing: - Test plan: Between steps 2 and 3, you need to check an item out for a record and use that record number for 'x' in step 3. Otherwise, the 'Checkout out' column doesn't display. This drove me a bit nuts trying to find the column (just kidding!). - The patch involves database updates. If you remove the branch used to test the bug (for example, git branch -D bz20491) and reset your koha repository (git reset --hard origin/master) then the column still displays as 'Due date'. You need to either reset the database (however you do that) or refresh your development environment (koha-testing-docker = CTRL C, docker-compose -p koha down, docker-compose -p koha up). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this patch is ok, but should be pushed without the atomicupdate. The problem is that we kind of have a rule to not mess with people's existing framework setups. As such we don't add new fields there usually for the MARC updates etc. The other major problem is that people with translated frameworks would find their translations overwritten by the English term. I am adding a follow-up removing the atomic-update, to be on the safe side, but it might be easier to do it on RM side :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84222|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84250&action=edit Bug 20491: Updating the MARC subfield desciption of 952q Test plan: 1) Go to admin, then to MARC frameworks, then to default frameworks structure, then subfield stucture for 952 2) Verify that 'q' is described as 'checked out' 3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 4) Verify that 'q' is also descirbed as 'Checked out' in 5) Apply patch and update your database 6) Verify that the description of 'q' has changed to 'Date due' 7) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 6) Verify that it has changed to 'Date due' Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84251&action=edit Bug 20491: (QA follow-up) Remove atomic update We should not update existing installations, especially since this would not work for translated frameworks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org