[Bug 20274] New: itemtypes.plugin report: not handling item-level_itypes syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Bug ID: 20274 Summary: itemtypes.plugin report: not handling item-level_itypes syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org == Reproduce == 1. Use staff:/cgi-bin/koha/reports/manager.pl?report_name=itemtypes 2. Change the syspref item-level_itypes 3. One case should give a 0 result == Cause == There is a conditional but part of the SQL query was copy pasted without being changed. == Fix == "SELECT itemtype" → "SELECT biblioitems.itemtype" in these two lines https://gitlab.com/koha-community/Koha/blob/673a40d2acc5c8c58b7f3e7e6d11c329... https://gitlab.com/koha-community/Koha/blob/673a40d2acc5c8c58b7f3e7e6d11c329... (or maybe the other ones) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 --- Comment #1 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84032&action=edit Bug 20274 When the system preference for item-level_itypes changed, it gave a zero result. 1) Go to reports then catalog by item types 2) Pick a location and look at table 3) Change the system prefernce of item-level_itypes 4) Verify a zero result 5) Apply patch and retry 6) Verify that result does not change to zero on either preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hickeyhe@wgc.school.nz |ity.org | CC| |hickeyhe@wgc.school.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84032|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 84138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84138&action=edit Bug 20274 When the system preference for item-level_itypes changed, it gives a zero result. 1) Go to reports then catalog by item types 2) Pick a location and look at table 3) Change the system prefernce of item-level_itypes 4) Verify a zero result 5) Apply patch and retry 6) Verify that result does not change to zero on either preference Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84138|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84144&action=edit Bug 20274: Itemtypes report gives zero results if item-level_itypes set to bibliographic records 1) Go to reports then catalog by item types 2) Pick a location and look at table 3) Change the system prefernce of item-level_itypes 4) Verify a zero result 5) Apply patch and retry 6) Verify that result does not change to zero on either preference Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Good fix! For next patch: please make sure the commit subject (the first line) follows the guidelines. You can run the qa script yourself before submitting so you can fix that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ok for this patch. But I think this file needs more work. I see : while (($itemtype, $description,$biblioitems,$total) = $sth->fetchrow) So first var is the item type. $biblioitems seems unused. This code is confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org