[Bug 17798] New: Checking out an item on hold for another patron prints a slip but does not update hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Bug ID: 17798 Summary: Checking out an item on hold for another patron prints a slip but does not update hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: Place a hold for patron A Do not confirm the hold Checkout that item to Patron B See the options including 'Don't checkout and print slip' Print the slip Check the item record The hold has not been confirmed and the item 'last seen' is not updated For consistency printing should confirm the hold as well and mark the item waiting or initiate a transfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm. In my case it was a transfer slip, but the item didn't get changed to the transport status and the hold remains pending. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is this a regression or a behaviour change request? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the button was introduced not so long ago - not sure if it ever worked differently, but it should work differently. Does that make sense? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Having a book with the hold slip in it... that is not actually waiting is bound to cause you a lot of headache. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 [Bug 11882] Add a new button to the checkout confirmation dialog when checking out an on hold item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com | |, | |simith.doliveira@inlibro.co | |m --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think if we can't fix this pre-release, we should consider removing the button altogether - at the moment I would hide it if I had a choice as a library, as the feature behind it is broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
To my understanding, this is what happened :
Situation 1 (regular)
- Patron A put a hold on Book A - Book A is returned. Hold is confirmed. - Patron B checkout Book A - Koha says "This book is on hold for Patron A, what do you want to do?" - The button "Don't checkout and print" allows you to cancel the process and print a slip. - It keeps the book on hold for Patron A. It's actually already on hold so there should be no reason to update it.
If the item is already on hold for the patron it will allow to reprint the hold slip. Sounds good.
BUT, here comes situation 2 (exception)
- Patron A put a hold on Book A - Book A is returned. Hold is NOT confirmed (Library wants to confirm the hold later to control when the confirmation email is sent, or library had forgotten, etc.) - Patron B checkout Book A - Koha says "This book is on hold for Patron A, what do you want to do?" - The button "Don't checkout and print" allows you to cancel the process and print a slip. - The hold is not confirmed and this button doesn’t update it.
I think that's wrong - you should not have a hold slip if no email is generated and the hold is not set to waiting. The slip should only happen if the hold is waiting or set to waiting - otherwise you end up with 'available' items on the hold shelf. I wonder if the message could be better as on hold sounds like it's already waiting, but it's not. We should have different messages for already waiting and having a hold on it that's not yet confirmed. I think what Nick describes is a 3rd option: hold for A, don't confirm hold, try to checkout to A. In this case, the item was not waiting and should be set to waiting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
To my understanding, this is what happened :
Situation 1 (regular)
- Patron A put a hold on Book A - Book A is returned. Hold is confirmed. - Patron B checkout Book A - Koha says "This book is on hold for Patron A, what do you want to do?" - The button "Don't checkout and print" allows you to cancel the process and print a slip. - It keeps the book on hold for Patron A. It's actually already on hold so there should be no reason to update it.
If the item is already on hold for the patron it will allow to reprint the hold slip. Sounds good.
BUT, here comes situation 2 (exception)
- Patron A put a hold on Book A - Book A is returned. Hold is NOT confirmed (Library wants to confirm the hold later to control when the confirmation email is sent, or library had forgotten, etc.) - Patron B checkout Book A - Koha says "This book is on hold for Patron A, what do you want to do?" - The button "Don't checkout and print" allows you to cancel the process and print a slip. - The hold is not confirmed and this button doesn’t update it.
I think that's wrong - you should not have a hold slip if no email is generated and the hold is not set to waiting. The slip should only happen if the hold is waiting or set to waiting - otherwise you end up with 'available' items on the hold shelf.
I wonder if the message could be better as on hold sounds like it's already waiting, but it's not. We should have different messages for already waiting and having a hold on it that's not yet confirmed.
I think what Nick describes is a 3rd option: hold for A, don't confirm hold, try to checkout to A. In this case, the item was not waiting and should be set to waiting.
Yes, as I follow things this is correct - I was thinking of the situation where: A places a hold from home B picks up the book off the shelf before a hold list is checked Try to checkout to B, print slip, hold never confirmed I think you are getting at language something like: this item has a hold for Patron A versus this item is on hold for Patron A -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23953 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin@inlibro.com |koha-bugs@lists.koha-commun | |ity.org Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158281&action=edit Bug 17798: Confirm hold when printing slip from another patron's account This patch adds a few pieces of information to the print slip button and makes the code confirm the hold As we are printing before the confirm, we also add the ability to pass in the itemnumber to 'ReserveSlip' This is slightly hacky, however, I don't see another way to allow printing without an additional page reload. To test: 1 - Place a title level hold for patron A, for delivery to library B 2 - Attempt to checkout an item from the record above to Patron B from library A 3 - You receive an alert about the hold 4 - Click "Don't check out, confirm hold, and print slip" 5 - Confirm the slip looks correct and has item info 6 - Confirm that item is in transit to fill hold 7 - Revert transit status 8 - Attempt to checkout the item to Patron B from Library B 9 - Click "Don't check out, confirm hold, and print slip" 10 - Confirm slip is correct 11 - Confirm item is marked waiting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158282&action=edit Bug 17798: Add fieldset for 'Yes, check out (Y)' With the increased text, the buttons don't arrange neatly. Adding a fieldset around the options for 'Yes' mitigates this somewhat - it could do with a bit more styling, however, it also fixes bug 23953 To test: Confirm the 'Yes' options are more clear that they only affect the yes button Confirm the other buttons arrange nicely -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158281|0 |1 is obsolete| | Attachment #158282|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158330&action=edit Bug 17798: Confirm hold when printing slip from another patron's account This patch adds a few pieces of information to the print slip button and makes the code confirm the hold As we are printing before the confirm, we also add the ability to pass in the itemnumber to 'ReserveSlip' This is slightly hacky, however, I don't see another way to allow printing without an additional page reload. To test: 1 - Place a title level hold for patron A, for delivery to library B 2 - Attempt to checkout an item from the record above to Patron B from library A 3 - You receive an alert about the hold 4 - Click "Don't check out, confirm hold, and print slip" 5 - Confirm the slip looks correct and has item info 6 - Confirm that item is in transit to fill hold 7 - Revert transit status 8 - Attempt to checkout the item to Patron B from Library B 9 - Click "Don't check out, confirm hold, and print slip" 10 - Confirm slip is correct 11 - Confirm item is marked waiting Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158331&action=edit Bug 17798: Add fieldset for 'Yes, check out (Y)' With the increased text, the buttons don't arrange neatly. Adding a fieldset around the options for 'Yes' mitigates this somewhat - it could do with a bit more styling, however, it also fixes bug 23953 To test: Confirm the 'Yes' options are more clear that they only affect the yes button Confirm the other buttons arrange nicely Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158332&action=edit Bug 17798: (follow-up) Adjust color of fieldset nested in .dialog.alert Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158330|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158387&action=edit Bug 17798: Confirm hold when printing slip from another patron's account This patch adds a few pieces of information to the print slip button and makes the code confirm the hold As we are printing before the confirm, we also add the ability to pass in the itemnumber to 'ReserveSlip' This is slightly hacky, however, I don't see another way to allow printing without an additional page reload. To test: 1 - Place a title level hold for patron A, for delivery to library B 2 - Attempt to checkout an item from the record above to Patron B from library A 3 - You receive an alert about the hold 4 - Click "Don't check out, confirm hold, and print slip" 5 - Confirm the slip looks correct and has item info 6 - Confirm that item is in transit to fill hold 7 - Revert transit status 8 - Attempt to checkout the item to Patron B from Library B 9 - Click "Don't check out, confirm hold, and print slip" 10 - Confirm slip is correct 11 - Confirm item is marked waiting Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158331|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158388&action=edit Bug 17798: Add fieldset for 'Yes, check out (Y)' With the increased text, the buttons don't arrange neatly. Adding a fieldset around the options for 'Yes' mitigates this somewhat - it could do with a bit more styling, however, it also fixes bug 23953 To test: Confirm the 'Yes' options are more clear that they only affect the yes button Confirm the other buttons arrange nicely Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158332|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158389&action=edit Bug 17798: (follow-up) Adjust color of fieldset nested in .dialog.alert Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |phil@chetcolibrary.org Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org