https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164420|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164421&action=edit Bug 36521: Checkbox preferences should be allowed to be submitted empty Visit: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n Uncheck English on both 'language' and 'OPACLanguages'. Save. Notice "Nothing to save" shows. Apply patch. Repeat. Notice you can now save with all options empty. To my knowledge, these 2 language preferences are the only checkbox preferences of this kind (correct me if I'm wrong please). I need to add a new system preference for bug 35604 listing all installed ILL backends so the user may enable or disable each of the backends. I want that particular system preference to be disabled as a whole if all backends are unchecked, but I was unable to uncheck all before this patch. I understand that for languages checkboxes specifically not allowing everything to be empty may make sense (at least one language should be enabled, after all). But these languages checkbox preferences should be the exception, not the rule, for this behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #2)

To my knowledge, these 2 language preferences are the only checkbox preferences of this kind (correct me if I'm wrong please).

There is this patch in the queue https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163699 But I don't think they will conflict. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Found a bug: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=lang language and opaclanguage have "English" Deselect English for language, save OK Deselect English for opaclanguage, save => "Nothing to save" FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164421|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164427&action=edit Bug 36521: Checkbox preferences should be allowed to be submitted empty Visit: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n Uncheck English on both 'language' and 'OPACLanguages'. Save. Notice "Nothing to save" shows. Apply patch. Repeat. Notice you can now save with all options empty. To my knowledge, these 2 language preferences are the only checkbox preferences of this kind (correct me if I'm wrong please). I need to add a new system preference for bug 35604 listing all installed ILL backends so the user may enable or disable each of the backends. I want that particular system preference to be disabled as a whole if all backends are unchecked, but I was unable to uncheck all before this patch. I understand that for languages checkboxes specifically not allowing everything to be empty may make sense (at least one language should be enabled, after all). But these languages checkbox preferences should be the exception, not the rule, for this behaviour. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Severity|enhancement |normal --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Trivial, bad bug, passing QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36521 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Fridolin Somers from comment #10)

Does not apply easy on 23.11.x. Please provide patches if needed.

Don't think it's needed. This is just a fix for a problem highlighted in bug 35604 where there is a need of being able to submit a checkbox preference as empty. Prior to bug 35604 (not yet pushed) the only checkbox preference(s) that exist is the language(s) preferences afaik and those work 'fine' not being able to submit empty. Happy to be corrected. -- You are receiving this mail because: You are watching all bug changes.