[Bug 36321] New: Problem when dateexpiry in BorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Bug ID: 36321 Summary: Problem when dateexpiry in BorrowerUnwantedField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When dateexpiry is in BorrowerUnwantedField it is hidden in patron edition form. The problem is when editing an existing patron the value is re-computed with category settings, as if it where empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 163137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163137&action=edit Bug 36321: Problem when dateexpiry in BorrowerUnwantedField hen dateexpiry is in BorrowerUnwantedField it is hidden in patron edition form. The problem is when editing an existing patron the value is re-computed with category settings, as if it where empty. This comes from all fields in BorrowerUnwantedField beeing removed from %newdata in memberentry.pl. Whe must skip dateexpiry. Test plan : 1) Be sure dateexpiry is not in BorrowerUnwantedField 2) Define a patron category with enrollment period 12 month 3) Create a new patron in this category 4) Its expiration date is in now + 12 month 5) Edit the patron category to set enrollment period 6 month 6) Add dateexpiry in BorrowerUnwantedField 7) Edit the patron and save => Without patch the expiration date is changed to now + 6 month => With patch the exporation date is unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163137|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 163144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163144&action=edit Bug 36321: Problem when dateexpiry in BorrowerUnwantedField hen dateexpiry is in BorrowerUnwantedField it is hidden in patron edition form. The problem is when editing an existing patron the value is re-computed with category settings, as if it where empty. This comes from all fields in BorrowerUnwantedField beeing removed from %newdata in memberentry.pl. Whe must skip dateexpiry. Test plan : 1) Be sure dateexpiry is not in BorrowerUnwantedField 2) Define a patron category with enrollment period 12 month 3) Create a new patron in this category 4) Its expiration date is in now + 12 month 5) Edit the patron category to set enrollment period 6 month 6) Add dateexpiry in BorrowerUnwantedField 7) Edit the patron and save => Without patch the expiration date is changed to now + 6 month => With patch the exporation date is unchanged Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163144|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163580&action=edit Bug 36321: Problem when dateexpiry in BorrowerUnwantedField hen dateexpiry is in BorrowerUnwantedField it is hidden in patron edition form. The problem is when editing an existing patron the value is re-computed with category settings, as if it where empty. This comes from all fields in BorrowerUnwantedField beeing removed from %newdata in memberentry.pl. Whe must skip dateexpiry. Test plan : 1) Be sure dateexpiry is not in BorrowerUnwantedField 2) Define a patron category with enrollment period 12 month 3) Create a new patron in this category 4) Its expiration date is in now + 12 month 5) Edit the patron category to set enrollment period 6 month 6) Add dateexpiry in BorrowerUnwantedField 7) Edit the patron and save => Without patch the expiration date is changed to now + 6 month => With patch the exporation date is unchanged Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to tidy :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org