[Bug 35364] New: Update label creator pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Bug ID: 35364 Summary: Update label creator pop-up windows with consistent footer markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 34343 I would like to update several serial module pop-up windows to be consistent with Bug 34343 and its children: - serials/acqui-search-result.tt - serials/acqui-search.tt - serials/result.tt - serials/subscription-bib-search.tt - serials/routing-preview-slip.tt - serials/subscription-renew.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159110&action=edit Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update label creator pop-up |Update serials pop-up |windows with consistent |windows with consistent |footer markup |footer markup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159110|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159720&action=edit Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the style of several | |serials module templates so | |that the submission and | |close buttons are in a | |fixed footer at the bottom | |of the pop-up windows, | |consistent with other | |pop-up windows. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159720|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163715&action=edit Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163715|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 163901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163901&action=edit Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163901|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 165228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165228&action=edit Bug 35364: Update serials pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org