[Bug 25834] New: Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Bug ID: 25834 Summary: Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The "search to add" label on the button for guarantors is a bit hard to translate and it lacks context (think of someone relying on a screen reader). I suggest using something like: "Search for guarantor" or "Add guarantor" instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi George, I see you added yourself CC - would the suggested change work for you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 --- Comment #2 from George Williams (NEKLS) <george@nekls.org> --- Yes, either would work, I think I prefer "Add guarantor" because it's simpler. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #4 from Lisette Scheer <lisetteslatah@gmail.com> --- I also prefer the "Add guarantor" option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 --- Comment #5 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 112395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112395&action=edit Attachment to Bug 25834 - Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form Bug 25834: Relabel "Search to add" to "Add guarantor" on patron form. The "search to add" label on the button for adding guarantors is a bit hard to translate and is inaccessable. This patch updated the button label to "Add guarantor" to fix these issues. To test: 1. Go to patrons 2. Add a new child patron 3. Observe the button with "search to add" 4. Save the patron 5. Edit the patron and observe the "search to add" button. 6. Apply patch. 7. Add a new patron 8. Observe new text on button. 9. Edit a child patron 10. Observe new text on button 11. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 112473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112473&action=edit Bug 25834: Relabel "Search to add" to "Add guarantor" on patron form. The "search to add" label on the button for adding guarantors is a bit hard to translate and is inaccessable. This patch updated the button label to "Add guarantor" to fix these issues. To test: 1. Go to patrons 2. Add a new child patron 3. Observe the button with "search to add" 4. Save the patron 5. Edit the patron and observe the "search to add" button. 6. Apply patch. 7. Add a new patron 8. Observe new text on button. 9. Edit a child patron 10. Observe new text on button 11. Sign off Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112473|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112474&action=edit Bug 25834: Relabel "Search to add" to "Add guarantor" on patron form. The "search to add" label on the button for adding guarantors is a bit hard to translate and is inaccessable. This patch updated the button label to "Add guarantor" to fix these issues. To test: 1. Go to patrons 2. Add a new child patron 3. Observe the button with "search to add" 4. Save the patron 5. Edit the patron and observe the "search to add" button. 6. Apply patch. 7. Add a new patron 8. Observe new text on button. 9. Edit a child patron 10. Observe new text on button 11. Sign off Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org