https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|pref |System preference |ArticleRequestsMandatoryFie |ArticleRequestsMandatoryFie |ldsItemsOnly is never used |ldsItemsOnly is unused -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111945&action=edit Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly The preference was probably added because of a typo, as there is a used system preference ArticleRequestsMandatoryFieldsItemOnly (Item vs Items). This patch fixes the situation: - syspref.sql had the pref name with the typo, this is fixed. - A database update removes the unused variable and makes sure the used one is added. To test: - Look at the local use system preferences, verify the false pref is there - Look at the other ArticleRequests* preferences, verify the other without "s" is there - Apply patch and run database update - Verify the local use tab one is gone now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111945|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 112483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112483&action=edit Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly The preference was probably added because of a typo, as there is a used system preference ArticleRequestsMandatoryFieldsItemOnly (Item vs Items). This patch fixes the situation: - syspref.sql had the pref name with the typo, this is fixed. - A database update removes the unused variable and makes sure the used one is added. To test: - Look at the local use system preferences, verify the false pref is there - Look at the other ArticleRequests* preferences, verify the other without "s" is there - Apply patch and run database update - Verify the local use tab one is gone now Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Confirmed the preference is not used, confirmed the DB update is idempotent, confirmed the QA tests pass. Passing QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.