[Bug 20260] New: Use CodeMirror for the SQL reports editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Bug ID: 20260 Summary: Use CodeMirror for the SQL reports editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org We are already using CodeMirror (http://codemirror.net) somewhere. I would guess in Rancor, the advanced cataloguing editor. How about also using it for syntax highlighting when editing the SQL of an SQL report? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- CodeMirror in SQL mode: http://codemirror.net/mode/sql/index.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Jens Weber <jens.weber@phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jens.weber@phsh.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75180&action=edit Bug 20260: Use CodeMirror for the SQL reports editor This patch adds CodeMirror syntax highlighting to the SQL reports editor. Newly added is a file containing the sql-specific syntax highlighting code, in both compressed and uncompressed versions. Unrelated change: Some JavaScript has been moved from inside the body of the page to the footer. To test, apply the patch and go to Reports -> Saved SQL reports - Edit an existing report and confirm that the SQL is correctly highlighted and that there are no display problems when editing. - Confirm that changes are saved successfully. - Perform the same test when creating a new SQL report. - View an existing report and confirm that the SQL is syntax-highlighted but is read-only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I've tried to also address Bug 19399 in these changes. If testers agree, please mark that bug as a duplicate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 75180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75180 Bug 20260: Use CodeMirror for the SQL reports editor Review of attachment 75180: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20260&attachment=75180) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ +31,4 @@
[%- END -%]</title>
[% INCLUDE 'doc-head-close.inc' %] +[% Asset.css("lib/codemirror/codemirror.css") %]
Where is this? @@ +953,4 @@
[% INCLUDE 'datatables.inc' %] [% INCLUDE 'columns_settings.inc' %] [% END %] + [% Asset.js( "lib/codemirror/codemirror-compressed.js" ) %]
Where is this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #5)
Where is this?
DOH! find . | grep codemirror and comment #0. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- It was beautiful (edit and create), but the show is empty. Inspecting the source, I see a display: none with the correct SQL outside the CodeMirror divs. I think Failed QA is appropriate, because of that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75180|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80367&action=edit Bug 20260: Use CodeMirror for the SQL reports editor This patch adds CodeMirror syntax highlighting to the SQL reports editor. Newly added is a file containing the sql-specific syntax highlighting code, in both compressed and uncompressed versions. Unrelated changes: - Some JavaScript has been moved from inside the body of the page to the footer. - Paths to some assets have been corrected to no use relative paths. To test, apply the patch and go to Reports -> Saved SQL reports - Edit an existing report and confirm that the SQL is correctly highlighted and that there are no display problems when editing. - Confirm that changes are saved successfully. - Perform the same test when creating a new SQL report. - View an existing report and confirm that the SQL is syntax-highlighted but is read-only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80367|0 |1 is obsolete| | --- Comment #9 from Michal Denar <black23@gmail.com> --- Created attachment 80419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80419&action=edit Bug 20260: Use CodeMirror for the SQL reports editor This patch adds CodeMirror syntax highlighting to the SQL reports editor. Newly added is a file containing the sql-specific syntax highlighting code, in both compressed and uncompressed versions. Unrelated changes: - Some JavaScript has been moved from inside the body of the page to the footer. - Paths to some assets have been corrected to no use relative paths. To test, apply the patch and go to Reports -> Saved SQL reports - Edit an existing report and confirm that the SQL is correctly highlighted and that there are no display problems when editing. - Confirm that changes are saved successfully. - Perform the same test when creating a new SQL report. - View an existing report and confirm that the SQL is syntax-highlighted but is read-only. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like that now when you make a mistake and it gives you a line number to look at, there are actually line numbers now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80431&action=edit Bug 21541: Use raw filter for report results To test: 1 - Create new report SELECT CONCAT('<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=',borrowernumber,'">',"",firstname,"",surname,'</a>') AS people FROM borrowers 2 - Run this report 3 - Note the results contain raw text, they are not hyperlinks 4 - Apply patch 5 - Reload the results 6 - They should now be links Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80419|0 |1 is obsolete| | Attachment #80431|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80432&action=edit Bug 20260: Use CodeMirror for the SQL reports editor This patch adds CodeMirror syntax highlighting to the SQL reports editor. Newly added is a file containing the sql-specific syntax highlighting code, in both compressed and uncompressed versions. Unrelated changes: - Some JavaScript has been moved from inside the body of the page to the footer. - Paths to some assets have been corrected to no use relative paths. To test, apply the patch and go to Reports -> Saved SQL reports - Edit an existing report and confirm that the SQL is correctly highlighted and that there are no display problems when editing. - Confirm that changes are saved successfully. - Perform the same test when creating a new SQL report. - View an existing report and confirm that the SQL is syntax-highlighted but is read-only. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just come across this, lovely enhancement! :) Won't be backported however.. too large a change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Any reason why this couldn't also be used for intranet/opacuserjs & intranet/opacusercss? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 --- Comment #16 from Magnus Enger <magnus@libriotech.no> --- (In reply to Andrew Isherwood from comment #15)
Any reason why this couldn't also be used for intranet/opacuserjs & intranet/opacusercss?
Sounds like an excellent idea to me. Create a new bug report for it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 --- Comment #17 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Done :) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21582 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org