[Bug 22196] New: Clean up Mana KB administration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Bug ID: 22196 Summary: Clean up Mana KB administration template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 17047 Target Milestone: --- There are some markup and content corrections to be made to the Mana KB administration template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84338&action=edit Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 22202 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84338|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84352&action=edit Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22198 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198 [Bug 22198] Add granular permission setting for Mana KB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84357&action=edit Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable Also changed: Some language revisions to the Mana dialogs on the Administration home page. To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84357|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84451&action=edit Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable Also changed: Some language revisions to the Mana dialogs on the Administration home page. To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84452&action=edit Bug 22196: (QA follow-up) Fix some typo Fixes the typo on the admin main page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like the clean-up, but from the discussion on the main bug I understood that the token is an optional feature and you would still be allowed to search for subscriptions/reports without it (what about commenting/rating?). If that's the case it would be nice to make this more clear in the documentation of the feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84451|0 |1 is obsolete| | Attachment #84452|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84503&action=edit Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable Also changed: Some language revisions to the Mana dialogs on the Administration home page. To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84504&action=edit Bug 22196: (QA follow-up) Fix some typo Fixes the typo on the admin main page. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84505&action=edit Bug 22196: (QA follow-up) Fix some more typo Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Bug 22196 depends on bug 17047, which changed state. Bug 17047 Summary: Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- *** Bug 22244 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- An enhancement to a new feature for 19.05, not need to backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org