[Bug 21341] New: Style button on acquisitions existing record search with Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Bug ID: 21341 Summary: Style button on acquisitions existing record search with Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When you add to a basket by searching existing records, the "View MARC" and "Order" links should be Bootstrap buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78598&action=edit Bug 21341: Style button on acquisitions existing record search with Bootstrap This patch adds Bootstrap button styles to two links: View MARC and Order. Unrelated: A "modal-wide" class has been added to the View MARC modal to give more room for the MARC view. To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record. In the record search results, confirm that the View MARC and Order links are now Bootstrap buttons. Test the View MARC button and confirm that the modal preview fills most of the screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78598|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 78834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78834&action=edit Bug 21341: Style button on acquisitions existing record search with Bootstrap This patch adds Bootstrap button styles to two links: View MARC and Order. Unrelated: A "modal-wide" class has been added to the View MARC modal to give more room for the MARC view. To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record. In the record search results, confirm that the View MARC and Order links are now Bootstrap buttons. Test the View MARC button and confirm that the modal preview fills most of the screen. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78834|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79264&action=edit Bug 21341: Style button on acquisitions existing record search with Bootstrap This patch adds Bootstrap button styles to two links: View MARC and Order. Unrelated: A "modal-wide" class has been added to the View MARC modal to give more room for the MARC view. To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record. In the record search results, confirm that the View MARC and Order links are now Bootstrap buttons. Test the View MARC button and confirm that the modal preview fills most of the screen. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21341 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org