[Bug 20534] New: Floating toolbar when editing vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Bug ID: 20534 Summary: Floating toolbar when editing vendors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When editing vendors with a lot of contacts, it would be nice to have a floating toolbar on top with the save button always visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73772&action=edit Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73772|0 |1 is obsolete| | --- Comment #2 from Maksim Sen <maksim.sen@inlibro.com> --- Created attachment 73786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73786&action=edit Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73786|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73826&action=edit Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wish all my wishes came true so fast :) Works flawlessly, thx Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, same problem as we had on the patron edit page: https://screenshots.firefox.com/pvWlqcxFqUDgRU0L/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73826|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79306&action=edit Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79307&action=edit Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org