[Bug 42077] New: Move RabbitMQ from mandatory to optional and make SQL polling the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Bug ID: 42077 Summary: Move RabbitMQ from mandatory to optional and make SQL polling the default Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 41506 On bug 41506 we discussed the option of removing RabbitMQ from the codebase. There appears to be consensus that a sensible first step is to update packages to make RabbitMQ optional and SQL polling the default. I believe this would still allow libraries to use RabbitMQ and even move it to a separate server without it installing on the Koha server. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41506 [Bug 41506] Should we remove RabbitMQ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mark@hofstetter.at |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Mark Hofstetter <mark@hofstetter.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 --- Comment #1 from Mark Hofstetter <mark@hofstetter.at> --- Created attachment 195839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195839&action=edit Bug 42077: Make polling the default jobs notification method and RabbitMQ optional Change the default value of JobsNotificationMethod from STOMP to polling for new installations and for the migration that inserts the preference. Adjust Debian package metadata so rabbitmq-server is no longer a hard dependency and is instead installed as an optional recommended package. This keeps RabbitMQ available for sites that want STOMP notifications, while making polling the default and avoiding a mandatory RabbitMQ installation. To test: 1. Confirm JobsNotificationMethod defaults to "polling" in sysprefs.sql. 2. Confirm the DB revision inserts JobsNotificationMethod with value "polling". 3. Confirm rabbitmq-server is no longer listed in Depends in debian/ control.in. 4. Confirm rabbitmq-server is listed as Recommends in debian/control.in. 5. Confirm the generated debian/control reflects the same dependency changes. 6. build koha debian packages, install them and check if "polling" is set JobsNotificationMethod and rabbitmq-server is not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |johanna.raisa@koha-suomi.fi --- Comment #2 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- The patch doesn't apply anymore, please fix the issue. Applying: Bug 42077: Make polling the default jobs notification method and RabbitMQ optional Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207310&action=edit Bug 42077: Make polling the default jobs notification method and RabbitMQ optional Change the default value of JobsNotificationMethod from STOMP to polling for new installations and for the migration that inserts the preference. Adjust Debian package metadata so rabbitmq-server is no longer a hard dependency and is instead installed as an optional recommended package. This keeps RabbitMQ available for sites that want STOMP notifications, while making polling the default and avoiding a mandatory RabbitMQ installation. To test: 1. Confirm JobsNotificationMethod defaults to "polling" in sysprefs.sql. 2. Confirm the DB revision inserts JobsNotificationMethod with value "polling". 3. Confirm rabbitmq-server is no longer listed in Depends in debian/ control.in. 4. Confirm rabbitmq-server is listed as Recommends in debian/control.in. 5. Confirm the generated debian/control reflects the same dependency changes. 6. build koha debian packages, install them and check if "polling" is set JobsNotificationMethod and rabbitmq-server is not installed Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207310|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207311&action=edit Bug 42077: Make polling the default jobs notification method and RabbitMQ optional Change the default value of JobsNotificationMethod from STOMP to polling for new installations and for the migration that inserts the preference. Adjust Debian package metadata so rabbitmq-server is no longer a hard dependency and is instead installed as an optional recommended package. This keeps RabbitMQ available for sites that want STOMP notifications, while making polling the default and avoiding a mandatory RabbitMQ installation. To test: 1. Confirm JobsNotificationMethod defaults to "polling" in sysprefs.sql. 2. Confirm the DB revision inserts JobsNotificationMethod with value "polling". 3. Confirm rabbitmq-server is no longer listed in Depends in debian/ control.in. 4. Confirm rabbitmq-server is listed as Recommends in debian/control.in. 5. Confirm the generated debian/control reflects the same dependency changes. 6. build koha debian packages, install them and check if "polling" is set JobsNotificationMethod and rabbitmq-server is not installed Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Edit: I made the `rabbitmq-server` package listed on `Suggests` instead, so it is not pulled unless explicit. I also removed the edit on the original dbrev that introduced the syspred as that's not how we do it. Loving this patch :-D (tcohen) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41506 | Blocks| |41506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41506 [Bug 41506] Should we remove RabbitMQ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I reversed the dependencies, as it might be too late on the release cycle to remove RabbitMQ, but we can make it not the default anymore for fresh installs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 207312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207312&action=edit Bug 42077: Make polling the default jobs notification method and RabbitMQ optional Change the default value of JobsNotificationMethod from STOMP to polling for new installations and for the migration that inserts the preference. Adjust Debian package metadata so rabbitmq-server is no longer a hard dependency and is instead installed as an optional recommended package. This keeps RabbitMQ available for sites that want STOMP notifications, while making polling the default and avoiding a mandatory RabbitMQ installation. To test: 1. Confirm JobsNotificationMethod defaults to "polling" in sysprefs.sql. 2. Confirm the DB revision inserts JobsNotificationMethod with value "polling". 3. Confirm rabbitmq-server is no longer listed in Depends in debian/ control.in. 4. Confirm rabbitmq-server is listed as Recommends in debian/control.in. 5. Confirm the generated debian/control reflects the same dependency changes. 6. build koha debian packages, install them and check if "polling" is set JobsNotificationMethod and rabbitmq-server is not installed Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Edit: I made the `rabbitmq-server` package listed on `Suggests` instead, so it is not pulled unless explicit. I also removed the edit on the original dbrev that introduced the syspred as that's not how we do it. Loving this patch :-D (tcohen) Signed-off-by: mason james <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43729 Status|Signed Off |Passed QA Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43729 [Bug 43729] Remove STOMP/RabbitMQ background jobs support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am happy to see this change as it will make our live a bit easier. What are the consequences for libraries already using RabbitMQ? Do we need to make sure that they are notified somehow? Adding the release-notes-needed as a first step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- @mason I think we are missing the postinst upgrade. It will always try to start rabbitmq on each upgrade, which should only happen if you are using STOMP. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org