https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to test this with a sandbox today (internal training session), but patch doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 41826: Update item type and authorized values pages to use grid layout for forms Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 41826: Update item type and authorized values pages to use grid layout for forms [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-41826-Update-item-type-and-authorized-values-p-qpg6dzeg.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195327|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195466&action=edit Bug 41826: Update item type and authorized values pages to use grid layout for forms This patch updates the authorized values and item types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authorized values - Administration -> Item types Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|Patch doesn't apply |Signed Off Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198841&action=edit Bug 41826: Update item type and authorized values pages to use grid layout for forms This patch updates the authorized values and item types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authorized values - Administration -> Item types Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200899&action=edit Bug 41826: Update item type and authorized values pages to use grid layout for forms This patch updates the authorized values and item types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authorized values - Administration -> Item types Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 201928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201928&action=edit Bug 41826: Update item type and authorized values pages to use grid layout for forms This patch updates the authorized values and item types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authorized values - Administration -> Item types Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203579&action=edit Bug 41826: Update item type and authorized values pages to use grid layout for forms This patch updates the authorized values and item types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authorized values - Administration -> Item types Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208106&action=edit Bug 41826: Update item type and authorized values pages to use grid layout for forms This patch updates the authorized values and item types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authorized values - Administration -> Item types Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 209382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209382&action=edit Bug 41826: Update item type and authorized values pages to use grid layout for forms This patch updates the authorized values and item types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authorized values - Administration -> Item types Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 209384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209384&action=edit Bug 41826: Restore min attribute on rental charge input Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209382|0 |1 is obsolete| | Attachment #209383|0 |1 is obsolete| | Attachment #209384|0 |1 is obsolete| | Attachment #209385|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 209512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209512&action=edit Bug 41826: Restore min attribute on rental charge input Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 209514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209514&action=edit Bug 41826: (follow-up) Checkbox labels should not end with colons This may be a remnant of earlier versions of the .fg grid layout, but the current pattern is to not end checkbox labels with ":" The patch also wraps the "Item type images are disabled" text and link with a <span> so that the two elements don't display as flex items. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41826 --- Comment #19 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.