[Bug 25478] New: Inconsistent naming of account_credit_type for lost and returned items [19.11 Version]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Bug ID: 25478 Summary: Inconsistent naming of account_credit_type for lost and returned items [19.11 Version] Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Keywords: rel_20_05_candidate, RM_priority Severity: blocker Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, bwsdonna@gmail.com, kelly@bywatersolutions.com, martin.renvoize@ptfs-europe.com, nick@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 25389, 22563, 23805 +++ This bug was initially created as a clone of Bug #25389 +++ Bug 23805 creates the account_credit_types table with the type "LOST_RETURN." Bug 22563 updates all existing "CR" account lines to "LOST_RETURNED." I've got no preference between the two wordings, but we should be consistent about it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 [Bug 25389] Inconsistent naming of account_credit_type for lost and returned items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104832&action=edit Bug 25478: (25389 backport) Correct original DB update for bug 22563 (cherry picked from commit ed564837a64a45bfd1551ab54417daf0a3b9c559) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104833&action=edit Bug 25478: (25389 backport) Correct stray cases of LOST_RETURNED The original DB update for bug 22563 incorrectly mapped CR to LOST_RETURNED as aposed to LOST_RETURN. This patch catches such cases and updates them in the update for bug 23805 (cherry picked from commit 483e40d2236bbb584022846bd1c85d62f149f096) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104834&action=edit Bug 25478: (25389 backport) Catch errant cases of LOST_RETURNED For upgrades taking place after the fix for the update in bug 24592 was pushed, we need to catch any last remaining error cases and correct them. (cherry picked from commit c5f34fe3ada46e29c9b1ac99b10186fab6d9670f) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A backport to make the application of bug 25389 to 19.11.x simple.. You will need to convert the final patch after push from the atomic update to a valid updatedatebase entry for your branch. Hope it helps Joy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Thanks Martin! Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org