[Bug 33664] New: Should we allow cancelling orders while the basket is closed?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Bug ID: 33664 Summary: Should we allow cancelling orders while the basket is closed? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, michaela.sieber@kit.edu This is a workflow question: At the moment cancelling an order line from the basket summary page is only possible, while the basket is open. For standing orders this means it's always possible, while it's not for other types of orders. There is now 2 ways to cancel the order: Option A: * Reopen the basket * Cancel the order * Close the basket + Less clicks than option B - All unreceived order lines will switch status unnecessarily (ordered - new - ordered) - The basket close date will reset to today's date Option B: * Create a new shipment * 'Fake' an invoice, for example it could be named: Cancellations * Use the cancelling options from the list of pending orders + Close date remains the same + Only the cancelled order line will change status - More clicks and not really convenient Now the question: Is there a strict reason why we should not permit cancelling from a closed order? The closed order lines will still show in the second table below. We could also add a hint on the cancellation date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> ---
From my library days, I would say it was very common for me to cancel orders I had already sent to the vendor. Mostly when the vendor would later tell me it was not available anymore or they would never get it.
In Koha, I'm not a fan of having to reopen the basket since like you said, it changes the order date. I had never tried option B. It seems like a fiddly workaround for something that should be possible.
From a workflow standpoint, I don't think there is a reason to limit cancelling orders to open baskets only.
From a technical standpoint, we should probably look at what closing the basket does, to know if something would clash with cancelling the order.
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- AFAIK it changes the status if it was new to ordered. If it was received it remains the same. Otherwise it should not change a thing and you can already cancel new from the basket and ordered from the receive page... so I think we should be ok. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #3 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Caroline Cyr La Rose from comment #1)
From my library days, I would say it was very common for me to cancel orders I had already sent to the vendor. Mostly when the vendor would later tell me it was not available anymore or they would never get it.
In Koha, I'm not a fan of having to reopen the basket since like you said, it changes the order date. I had never tried option B. It seems like a fiddly workaround for something that should be possible.
I agree. And yes, it is common to cancel order lines because titles are not available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28771 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov, | |rkuiper@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #4 from mathieu saby <mathsabypro@gmail.com> --- We often cancel orders, from reception module. It would be more convenient to be able to cancel orders from basket -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should we allow cancelling |Add ability to cancel order |orders while the basket is |lines in closed baskets |closed? | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154045&action=edit Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154045|0 |1 is obsolete| | --- Comment #6 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154053&action=edit Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.hanhisalo@xamk.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154053|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157979&action=edit Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Too many changes on this template lately, but all nicely rebased now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157979|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158075&action=edit Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158076&action=edit Bug 33664: (follow-up) Move check for 'received' to include Modify link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158075|0 |1 is obsolete| | Attachment #158076|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158077&action=edit Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158078&action=edit Bug 33664: (follow-up) Move check for 'received' to include Modify link Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Needs documenting --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With the new system release notes| |preference | |CancelOrdersInClosedBaskets | |it's now possible to allow | |for cancelling order lines | |from closed baskets. This | |is useful if something | |cannot be delivered and you | |don't want to reopen the | |basket or use go through | |the receive shipment | |process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|With the new system |With the new system release notes|preference |preference |CancelOrdersInClosedBaskets |CancelOrdersInClosedBaskets |it's now possible to allow |it's now possible to allow |for cancelling order lines |for cancelling order lines |from closed baskets. This |from closed baskets. This |is useful if something |is useful if something |cannot be delivered and you |cannot be delivered and you |don't want to reopen the |don't want to reopen the |basket or use go through |basket or use go through |the receive shipment |the receive shipment |process. |process. | | | |**Sponsored by** | |The Research University in | |the Helmholtz Association | |(KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|With the new system |With the new system release notes|preference |preference |CancelOrdersInClosedBaskets |CancelOrdersInClosedBaskets |it's now possible to allow |it's now possible to allow |for cancelling order lines |for cancelling order lines |from closed baskets. This |from closed baskets. This |is useful if something |is useful if something |cannot be delivered and you |cannot be delivered and you |don't want to reopen the |don't want to reopen the |basket or use go through |basket or use go through |the receive shipment |the receive shipment |process. |process. | | |**Sponsored by** |**Sponsored by** |The Research University in |*The Research University in |the Helmholtz Association |the Helmholtz Association |(KIT) |(KIT)* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the|With the new system |With the new system release notes|preference |preference |CancelOrdersInClosedBaskets |`CancelOrdersInClosedBasket |it's now possible to allow |s` it's now possible to |for cancelling order lines |allow for cancelling order |from closed baskets. This |lines from closed baskets. |is useful if something |This is useful if something |cannot be delivered and you |cannot be delivered and you |don't want to reopen the |don't want to reopen the |basket or use go through |basket or use go through |the receive shipment |the receive shipment |process. |process. | | |**Sponsored by** |**Sponsored by** |*The Research University in |*The Research University in |the Helmholtz Association |the Helmholtz Association |(KIT)* |(KIT)* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/813 Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18360 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org