[Bug 20935] New: Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Bug ID: 20935 Summary: Redesign system preferences interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 76039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76039&action=edit Screenshot showing system preferences standard view I think the system preferences page could use some work to make it more readable. My proposal does this: - Restructure the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76040&action=edit Screenshot showing system preferences filtered using in-page filter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76041&action=edit Screenshot showing system preferences search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76097&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 76106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76106&action=edit Screenshot of the system preferences page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- When I apply the patch, it doesn't look the same as the screenshots. The section headings are blue and the syspref names are almost the same as their description. making it hard to read. I like it, but would like the syspref names to be at least in bold. Also, would it be possible to keep the same indent as the first line on the 2nd + line of the description? For example, in my screenshot, in the description for gist, the second line, starting at "rounded" doesn't have the same indent as the line above. I think it makes it look messy. I would miss the arrows to collapse a section (when they're really long, it saves scrolling energy). Would it still be possible to have them in this new design? It's not the end of the world if it's not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Caroline Cyr La Rose from comment #5)
When I apply the patch, it doesn't look the same as the screenshots.
Did you clear your browser cache? That could explain the difference in what you see. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 76097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76097 Bug 20935: Redesign system preferences interface Review of attachment 76097: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20935&attachment=76097) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt @@ +156,5 @@
+ </div> <!-- /.col-sm-10.col-sm-push-2 --> + + <div class="col-sm-2 col-sm-pull-10"> + <aside> + [% INCLUDE 'admin-menu.inc' %]
should be prefs-menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Also, the "Local use" preferences are not addressed in this patch But great work Owen, I like this style! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- * I would not add the alert box when nothing is found * Left navigation is replaced by the admin one, instead of the pref specific one (prefs-menu.inc vs admin-menu.inc), I do not think it's expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76097|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76548&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #8)
Also, the "Local use" preferences are not addressed in this patch
The local use tab wasn't updated in the last round of interface changes, so I didn't think it was a priority. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76548|0 |1 is obsolete| | --- Comment #12 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 76664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76664&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just some small remarks, no blockers: Instead of "Click to edit" and "Click to collapse" I think it should just be "Edit" and "Collapse" as there is no need to extra label a link for clicking. Also... I think the German translation would be horribly long :) Attaching a patch with the suggested change, feel free to disagree! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76664|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76754&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76755&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is no question that this is more modern and prettier looking than before. The new filter functionality is a great addition, as are the "(modified)" labels on prefs changed. I am still a little torn on usability. I have the impression that it takes me a little longer to find things with the new styling. In the old interface the prefs were (ugly) Courier and in one column, so scanning over the page was pretty fast. This might be just a thing of 'being used to the old way'. I'd love another opinion as this is a bigger change and it would be good to get another set of eyes on it. Could be another sign-off or QA opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- When there is a match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org When there is no match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org The "Acquisitions preferences" h2 is display under the toolbar (I have selected the text to show it on the screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77163&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Found and fix an ergonomic bug with the toolbar on bug 21099. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21099 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #17)
When there is a match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org
When there is no match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org
The "Acquisitions preferences" h2 is display under the toolbar (I have selected the text to show it on the screenshot.
I have no idea how to fix that. I have also noticed that fixFloat duplicate the toolbar node (one is hidden), and so we should not have an id on them. Passing QA as it is a minor ergonomic issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76754|0 |1 is obsolete| | Attachment #76755|0 |1 is obsolete| | Attachment #77163|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77165&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77166&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77167&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77165|0 |1 is obsolete| | Attachment #77166|0 |1 is obsolete| | Attachment #77167|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77707&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77708&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77709&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77707|0 |1 is obsolete| | Attachment #77708|0 |1 is obsolete| | Attachment #77709|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77844&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77845&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77846&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have found a small regression added by the toolbar changes (bug 21139), RM please push the follow-up I have attached on it along with these patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20)
(In reply to Jonathan Druart from comment #17)
When there is a match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org
When there is no match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org
The "Acquisitions preferences" h2 is display under the toolbar (I have selected the text to show it on the screenshot.
I have no idea how to fix that. I have also noticed that fixFloat duplicate the toolbar node (one is hidden), and so we should not have an id on them.
Passing QA as it is a minor ergonomic issue.
Hum, I have posted twice the same link! When there is no match: https://screenshots.firefox.com/E2ey9Akb68rPHngV/pro.kohadev.org This is still valid, but minor and can be pushed as it IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Please rebase on 13618 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77844|0 |1 is obsolete| | Attachment #77845|0 |1 is obsolete| | Attachment #77846|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79177&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79178&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79179&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, what happened here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #36)
Hi Owen, what happened here?
I wanted to try to address some comments and suggestions I got during Hackfest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79177|0 |1 is obsolete| | Attachment #79178|0 |1 is obsolete| | Attachment #79179|0 |1 is obsolete| | --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82884&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82885&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82886&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82887&action=edit Bug 20935: Add in-page links to the sidebar This patch adds links to the sidebar menu which allow the user to jump to a section within the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- I was asked to add alternate-row highlighting to this but I found that it made it less readable rather than more. So I didn't do that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82888&action=edit Bug 20935: Add missing html filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Some comments I made on irc, but thought should be recorded here. Functionality wise I can't find any issues, it all works as expected. However: * I think we need to make the left menu float as you can no longer collapse preference sections and instead use the left menu more frequently to navigate between sections. * Somehow although it's spaced out more, it feels less readable and clear.. we're highlighting the non-descriptive in many cases syspref codes/names but making the actual descriptions and options a bit smaller. * Sometimes it's a good thing to have more on the page, this change introduces a not-insignificant descrease in data per page and as such results in more scrolling to find the preference you want (assuming you can't remember it's name enough to search / filter for it. I really want to like this update and I do think it looks more modern, but I can't happily go for it right now I'm afraid. Hugs to Owen for giving it a good try.. I look forward to more feedback being given and perhaps being over-ruled on this one.. It would be a great area to smarten up but I don't think we're quit there yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82884|0 |1 is obsolete| | Attachment #82885|0 |1 is obsolete| | Attachment #82886|0 |1 is obsolete| | Attachment #82887|0 |1 is obsolete| | Attachment #82888|0 |1 is obsolete| | --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86784&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86785&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86786&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86787&action=edit Bug 20935: Add in-page links to the sidebar This patch adds links to the sidebar menu which allow the user to jump to a section within the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86788&action=edit Bug 20935: Add missing html filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Rebase only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86784|0 |1 is obsolete| | Attachment #86785|0 |1 is obsolete| | Attachment #86786|0 |1 is obsolete| | Attachment #86787|0 |1 is obsolete| | Attachment #86788|0 |1 is obsolete| | --- Comment #51 from Michal Denar <black23@gmail.com> --- Created attachment 86833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86833&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #52 from Michal Denar <black23@gmail.com> --- Created attachment 86834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86834&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #53 from Michal Denar <black23@gmail.com> --- Created attachment 86835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86835&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #54 from Michal Denar <black23@gmail.com> --- Created attachment 86836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86836&action=edit Bug 20935: Add in-page links to the sidebar This patch adds links to the sidebar menu which allow the user to jump to a section within the page. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #55 from Michal Denar <black23@gmail.com> --- Created attachment 86837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86837&action=edit Bug 20935: Add missing html filter Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 86837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86837 Bug 20935: Add missing html filter Review of attachment 86837: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20935&attachment=86837) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt @@ +38,4 @@
<div id="toolbar"> Results in sections: [% FOREACH TAB IN TABS %] + <a href="#[% TAB.tab_title | url %]">[% TAB.tab_title | html %]</a>[% UNLESS ( loop.last ) %] • [% END %]
In fragment you should use uri filter, not url. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- I have question about multiselect fields: - Should the text be blue? I think we could stay with black here - The width of multiselect field is set bad, so there is scrollbar at the bottom, is it possible to do something with that? See screenshot: https://prnt.sc/n0u6ji Marking Failed QA means I need answer here. Otherwise it is looking good. (Just the small issue with uri/url filter) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86833|0 |1 is obsolete| | Attachment #86834|0 |1 is obsolete| | Attachment #86835|0 |1 is obsolete| | Attachment #86836|0 |1 is obsolete| | Attachment #86837|0 |1 is obsolete| | --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89936&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #59 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89937&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89938&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #61 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89939&action=edit Bug 20935: Add in-page links to the sidebar This patch adds links to the sidebar menu which allow the user to jump to a section within the page. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #62 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89940&action=edit Bug 20935: Add missing html filter Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org