https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #100 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to David Nind from comment #97)

I have tested (using koha-testing-docker), so that there is a sign-off from someone other than InLibro staff.

Notes from testing:

1. There are whitespace errors when applying the patches. [1]

2. Formatting patch titles - these should be in the format Bug XXXX: The title for the patch AND Bug XXXX: (follow-up) The title for the follow-up (see https://wiki.koha-community.org/wiki/Commit_messages#Subject_line).

3. Patches with the same name - this can be confusing, but I'm not sure of the best way to do this for this bug. Also, as this bug has been around for a while, and has a bit of history, maybe the patches should be consolidated. I would ask on IRC to get expert advice on the best approach to take for this bug (maybe have the main patch, a patch for the database update, and a patch for test changes).

4. Running updatedatabase produced no output on the command line for me - normally it does. The way to do database updates changed a while ago, but I don't know enough about how this works to comment. Maybe ask on IRC or see https://wiki.koha-community.org/wiki/Database_updates However, the new system preference RedirectGuaranteeEmail appears for me.

5. Running the tests fail for: prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t [2]

6. Comment #70 - not sure whether any of the issues raised have been addressed, or whether these should be addressed in a separate bug.

I've made some fixes to the patch -- You are receiving this mail because: You are watching all bug changes.