[Bug 9693] New: Remove YUI styling from buttons on the patron card creator's image manage page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Bug ID: 9693 Summary: Remove YUI styling from buttons on the patron card creator's image manage page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/search.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Several buttons on the patron card creator's image manage page are styled using YUI. Typically we don't apply special button styling to submit buttons, so to make this page consistent with others in Koha I propose to remove YUI styling. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15619&action=edit Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page Buttons on the patron card creator's image manage page are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Markup corrections for validity. To test, view the patron card creator's image manage page. "Upload" and "Delete" buttons should look correct and work correctly. Upload and delete operations should function normally. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|/cgi-bin/koha/catalogue/sea |/cgi-bin/koha/patroncards/i |rch.pl |mage-manage.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15630&action=edit pre-patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15631&action=edit post-patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15632&action=edit upload -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15633&action=edit delete -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, 1) Added pre and post screen. Is that (post) the final look? 2) When you upload or delete a file, a box indicating the action appears, and a few seconds later disappears. With patch applied, they do not disappear any more. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #6)
1) Added pre and post screen. Is that (post) the final look?
Yes: A submit button with default styling and a plain "cancel" link, consistent with other "save/cancel" pairs throughout Koha.
2) When you upload or delete a file, a box indicating the action appears, and a few seconds later disappears. With patch applied, they do not disappear any more.
This is a change peripheral to the patch, so I should have mentioned it: This kind of interface behavior is non-standard and I removed it rather than update it along with other JavaScript changes. The disappearing effect isn't required for functionality, leaving messages visible could be helpful to users who are not watching the screen constantly during these operations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15619|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15637&action=edit [SIGNED-OFF] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page Buttons on the patron card creator's image manage page are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Markup corrections for validity. To test, view the patron card creator's image manage page. "Upload" and "Delete" buttons should look correct and work correctly. Upload and delete operations should function normally. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Questions answered in comments. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15637|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15829&action=edit [PASSED QA] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page Buttons on the patron card creator's image manage page are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Markup corrections for validity. To test, view the patron card creator's image manage page. "Upload" and "Delete" buttons should look correct and work correctly. Upload and delete operations should function normally. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Questions answered in comments. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely and is more consistent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9693 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org