[Bug 9694] New: Remove YUI styling from buttons on the patron card creator manage pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Bug ID: 9694 Summary: Remove YUI styling from buttons on the patron card creator manage pages Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/patroncards/manage.pl?card_element= OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Several buttons on the patron card creator's manage page (used to manage layouts, profiles, etc) are styled using YUI. Typically we don't apply special button styling to submit buttons, so to make this page consistent with others in Koha I propose to remove YUI styling. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15620&action=edit Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15624&action=edit Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15624|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15635&action=edit [SIGNED-OFF] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. On errors. Tested all manage pages, edit, delete, and export buttons. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15635|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15875&action=edit [PASSED QA] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. On errors. Tested all manage pages, edit, delete, and export buttons. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, improves consistency. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9694 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org