[Bug 19074] New: Show patron category description instead of code in patron batch modification list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Bug ID: 19074 Summary: Show patron category description instead of code in patron batch modification list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When editing mulitple patrons unsing the patron batch modification tool, the list of patrons shows the patron category code instead of the patron category description. As the pull down below has the description, this can be quite confusing to some users and makes it harder to verify the correct results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 --- Comment #1 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 65798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65798&action=edit Bug 19074: bugfix: Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alex.sassmannshausen@ptfs-e | |urope.com --- Comment #2 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Accidentally uploaded patch to wrong bug. Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65798|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 --- Comment #3 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 65800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65800&action=edit Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 --- Comment #4 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- (In reply to Alex Sassmannshausen from comment #3)
Created attachment 65800 [details] [review] Bug 19074: Fix category display in Batch patron modification.
* tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it.
Test Plan: - Check that patron categories display in a human friendly way throughout batch modification tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65800|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 65806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65806&action=edit [SIGNED OFF] Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65806|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65839&action=edit Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65840&action=edit Bug 19074: Do not crash if cardnumber does not exist If a cardnumber does not exist, $borrower will be undef and the ->category call will explode Can't call method "category" on an undefined value at /home/vagrant/kohaclone/tools/modborrowers.pl line 370. This patch makes sure the patron exists before calling any methods. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Patch does not apply on 17.05.x because of Bug 17829. Since this is a minor, I propose to set as resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org