https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63241&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons https://bugs.koha-community.org/show_bug.cgi?id=15855 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63242|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63284&action=edit [SIGNED-OFF] Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Nice! A couple things: 1 - Duplicated code for testing the input and generating the list name - we should really only bother inside the check to create a list or not 2 - We should link from the results page to the newly created list 3 - We may want to optionally include overwritten borrowers in the list, they are sort of imported - I see use case in a school that overwrites patrons to update contact info/expiration and may generate new cards regularly -not blocker but would be nice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marc Véron from comment #6)

(In reply to Nick Clemens from comment #5) Can you elaborate a little bit what you mean by 1) ?

109 #create a patronlist 110 my $createpatronlist = $input->param('createpatronlist') || 0; 111 my $dt = dt_from_string(); 112 my $timestamp = $dt->ymd('-').' '.$dt->hms(':'); 113 my $patronlistname = $uploadborrowers . ' (' . $timestamp .')'; 124 #create a patronlist 125 my $createpatronlist = $input->param('createpatronlist'); 126 my $dt = dt_from_string(); 127 my $timestamp = $dt->ymd('-').' '.$dt->hms(':'); 128 my $patronlistname = $uploadborrowers. ' (' . $timestamp .')'; We do this twice - if createpatronlist isn't checked we don't need to do the rest of the setup

2) and 3) could go to a new bug based on this one - I have not much time ATM.

I will try to provide a followup or open a new bug for these. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Marc Véron <veron@veron.ch> --- Hope it's OK to set back to SO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63284|0 |1 is obsolete| | Attachment #65614|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65852&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65853&action=edit Bug 18555: (QA-Followup) Remove duplicate code Remove duplicate code as of comment #7 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.