[Bug 34269] New: Regression in circulation rules for 'similar' patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Bug ID: 34269 Summary: Regression in circulation rules for 'similar' patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 30517 loosens the regular expression used in the edit functionality of the circulation rules matrix in an attempt to make translations work.. However it has caused a regression for the case where a library may have similarly named patron categories (and likely also for item types). Our partner has the following valid patron categories: "Staff", "Staff (ISA)", "Staff (temporary)" and "Staff (zero entitlements)" With the regular expression change introduced in bug 30517, the first three categories all get reduced to just `staff` and as such you can no longer edit rules that contain those categories. We really shouldn't be relying on a regular expression here at all.. we should be able to pass in the codes rather than descriptions and utilise those for matching against. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30517 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 [Bug 30517] Translation breaks editing parent type circulation rule -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com, | |jonathan.druart+koha@gmail. | |com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153407&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153407|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153408&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153408|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153456&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. 0. Apply patch 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type Example: Create a 'Children's books' itemtypetype and assig 'Books' as its parent 3. Create a third item type with the same description but something added in (): Example: 'Children's books (3-5)' 3. Create a circulation rule for the parent type Example: All/Books, with 2 checkouts allowed 4. Create a circulation rule for: All/All with 3 checkouts allowed 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> The All/Books rule is modified 9. Add rules for Children's books and Children's books (3-5) 10. Click on "Edit" next to each rule and change a value --> Verify that the changed values are always saved for the correct rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153457&action=edit Bug 34269: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Conflict with bug 33028. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153456|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153985&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. 0. Apply patch 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type Example: Create a 'Children's books' itemtypetype and assig 'Books' as its parent 3. Create a third item type with the same description but something added in (): Example: 'Children's books (3-5)' 3. Create a circulation rule for the parent type Example: All/Books, with 2 checkouts allowed 4. Create a circulation rule for: All/All with 3 checkouts allowed 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> The All/Books rule is modified 9. Add rules for Children's books and Children's books (3-5) 10. Click on "Edit" next to each rule and change a value --> Verify that the changed values are always saved for the correct rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153457|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153986&action=edit Bug 34269: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153985|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153987&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. 0. Apply patch 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type Example: Create a 'Children's books' itemtypetype and assig 'Books' as its parent 3. Create a third item type with the same description but something added in (): Example: 'Children's books (3-5)' 3. Create a circulation rule for the parent type Example: All/Books, with 2 checkouts allowed 4. Create a circulation rule for: All/All with 3 checkouts allowed 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> The All/Books rule is modified 9. Add rules for Children's books and Children's books (3-5) 10. Click on "Edit" next to each rule and change a value --> Verify that the changed values are always saved for the correct rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153986|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153988&action=edit Bug 34269: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looks like my SO lines here are missing - I'll fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153987|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154074&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. 0. Apply patch 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type Example: Create a 'Children's books' itemtypetype and assig 'Books' as its parent 3. Create a third item type with the same description but something added in (): Example: 'Children's books (3-5)' 3. Create a circulation rule for the parent type Example: All/Books, with 2 checkouts allowed 4. Create a circulation rule for: All/All with 3 checkouts allowed 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> The All/Books rule is modified 9. Add rules for Children's books and Children's books (3-5) 10. Click on "Edit" next to each rule and change a value --> Verify that the changed values are always saved for the correct rule Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153988|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154075&action=edit Bug 34269: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Processing files before patches File not found : css/staff-global.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. Processing files after patches File not found : css/staff-global.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. Please explain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #14)
Processing files before patches File not found : css/staff-global.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107.
Processing files after patches File not found : css/staff-global.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107.
Please explain.
Hmm. Dont bother. I ran build resources again ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154074|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154255&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. 0. Apply patch 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type Example: Create a 'Children's books' itemtypetype and assig 'Books' as its parent 3. Create a third item type with the same description but something added in (): Example: 'Children's books (3-5)' 3. Create a circulation rule for the parent type Example: All/Books, with 2 checkouts allowed 4. Create a circulation rule for: All/All with 3 checkouts allowed 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> The All/Books rule is modified 9. Add rules for Children's books and Children's books (3-5) 10. Click on "Edit" next to each rule and change a value --> Verify that the changed values are always saved for the correct rule Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154075|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154256&action=edit Bug 34269: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- <td data-code="[%- IF auto_renew -%]yes[%- ELSE -%]no[%- END -%]"> Lets hope this does not appear in translation files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org