[Bug 34155] New: OPAC item level holds "force" option broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Bug ID: 34155 Summary: OPAC item level holds "force" option broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: normal Priority: P5 - low Component: OPAC Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: kyle@bywatersolutions.com, tomascohen@gmail.com Depends on: 24860 If I set OPAC item level holds to "force" in Circulation and Fine rules, when I go to place a hold in the OPAC I'm still given the option of choosing "next available." git bisect says the cause is Bug 24860: "Add ability to select an item group when placing a hold - OPAC" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 [Bug 24860] Add ability to place item group level holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 153532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153532&action=edit Bug 34155: Hide 'Next available' at OPAC when item-level hold is forced This was a regression caused by bug 24860 Test plan: 1. Set up circulation rules so that OPAC users can place holds only on specific items ("OPAC item level holds" = "force") 2. Try to place a hold at OPAC. The "Next available item" option should not appear. 3. Set "OPAC item level holds" to "allow" 4. Try to place a hold at OPAC. The "Next available item" option should appear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153532|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153537&action=edit Bug 34155: Hide 'Next available' at OPAC when item-level hold is forced This was a regression caused by bug 24860 Test plan: 1. Set up circulation rules so that OPAC users can place holds only on specific items ("OPAC item level holds" = "force") 2. Try to place a hold at OPAC. The "Next available item" option should not appear. 3. Set "OPAC item level holds" to "allow" 4. Try to place a hold at OPAC. The "Next available item" option should appear Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Isn't there a flaw in the controller as well? See bug 24860 comment 231. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Isn't there a flaw in the controller as well? See bug 24860 comment 231.
Indeed. In my opinion we should use only 'bibitemloo.forced_hold_level' in TT if possible. bibitemloo.force_hold is not very explicit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153537|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154059&action=edit Bug 34155: Hide 'Next available' at OPAC when item-level hold is forced This was a regression caused by bug 24860 Test plan: 1. Set up circulation rules so that OPAC users can place holds only on specific items ("OPAC item level holds" = "force") 2. Try to place a hold at OPAC. The "Next available item" option should not appear. 3. Set "OPAC item level holds" to "allow" 4. Try to place a hold at OPAC. The "Next available item" option should appear Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #4)
(In reply to Jonathan Druart from comment #3)
Isn't there a flaw in the controller as well? See bug 24860 comment 231.
Indeed.
In my opinion we should use only 'bibitemloo.forced_hold_level' in TT if possible. bibitemloo.force_hold is not very explicit.
This patch works for now, but I am all for fixing it up at a higher level too. Maybe we can compromise to do that on a separate bug? Unless someone wants to do a quick bugfix here? We left this unfixed for a month now, that's not good for this type of bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #6)
Unless someone wants to do a quick bugfix here? We left this unfixed for a month now, that's not good for this type of bug.
Backporting bad bugfixes is worst. Code in the controller must be cleaned before push in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #7)
(In reply to Katrin Fischer from comment #6)
Unless someone wants to do a quick bugfix here? We left this unfixed for a month now, that's not good for this type of bug.
Backporting bad bugfixes is worst. Code in the controller must be cleaned before push in my opinion.
So we just keep it broken, because noone is going to write that fix apparently? This was filed a month ago, is a user facing issue in stable releases. The patch is really small, it will be quite easy to do a proper fix on top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org