[Bug 11833] New: Reports Subgroups broken in 3.14
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Bug ID: 11833 Summary: Reports Subgroups broken in 3.14 Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: jesse@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 25597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25597&action=edit Report Subgroup The reports subgroups feature no longer works. "No matching reports found" each time I choose a reports subgroup. I thought it might be because the description name was too long or had a space in it or a hyphen in it or was a branch limited category, but none of those panned out. All subgroups do not work in 3.14. All the groups work when All is selected. But when a subgroup is selected, "no matching reports found" is the result. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.14 |master Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Summary|Reports Subgroups broken in |Filtering on saved report |3.14 |subgroup doesn't work -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25627&action=edit Bug 11833 - Filtering on saved report subgroup doesn't work Filtering the list of saved reports by subgroup doesn't work because the filtering JavaScript was not updated when the table columns changed with Bug 3134. This patch corrects the target column for filtering. To test you must have multiple saved reports within one group, and at least one of those in a subgroup. - Apply the patch and go to Reports -> Use saved. - Click the tab for the group which contains your reports. - Choose the subgroup you want to filter on from the subgroup dropdown. The list of reports should be correctly filtered by your subgroup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25627|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25630&action=edit [SIGNED OFF] Bug 11833 - Filtering on saved report subgroup doesn't work Filtering the list of saved reports by subgroup doesn't work because the filtering JavaScript was not updated when the table columns changed with Bug 3134. This patch corrects the target column for filtering. To test you must have multiple saved reports within one group, and at least one of those in a subgroup. - Apply the patch and go to Reports -> Use saved. - Click the tab for the group which contains your reports. - Choose the subgroup you want to filter on from the subgroup dropdown. The list of reports should be correctly filtered by your subgroup. NOTE: It seems weird to have the number of columns displayed change when filtered, but this patch does correct the filtering. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25630|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26161&action=edit [PASSED QA] Bug 11833 - Filtering on saved report subgroup doesn't work Filtering the list of saved reports by subgroup doesn't work because the filtering JavaScript was not updated when the table columns changed with Bug 3134. This patch corrects the target column for filtering. To test you must have multiple saved reports within one group, and at least one of those in a subgroup. - Apply the patch and go to Reports -> Use saved. - Click the tab for the group which contains your reports. - Choose the subgroup you want to filter on from the subgroup dropdown. The list of reports should be correctly filtered by your subgroup. NOTE: It seems weird to have the number of columns displayed change when filtered, but this patch does correct the filtering. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11833 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org