[Bug 19340] New: Transferred orders show incorrect basket in transferred from/to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Bug ID: 19340 Summary: Transferred orders show incorrect basket in transferred from/to Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org If you transfer an order from basket A to basket B The order in basket A is cancelled and should show "Transferred to basket B' A new order is created in basket B and should show Transferred from basket A. Currently the orders erroneously show the same basket as the order is in i.e. Basket A shows transferred to Basket A Basket B shows transferred from Basket B The reason is the order does not read the basket details and inadvertantly defaults to the owning basket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 67201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67201&action=edit Patch to read correct basket data Simple patch can be easily tested. Transfer an order line from one basket and supplier to another. When displaying the two baskets, the basketname and supplier appearing in the transferred from/to message in the orderline will incorrectly be those of the current basket. Apply the patch and the supplier and basketname should display the correct values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 --- Comment #2 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67331&action=edit Bug 19340 Read basket details of transfer partner Details of the basket an order is tranferred to or from are displayed in the basket display. Unfortunately these details were not being read so the display incorrectly showed the details of the current owning basket. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com Attachment #67201|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67331|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67779&action=edit Bug 19340 Read basket details of transfer partner Details of the basket an order is tranferred to or from are displayed in the basket display. Unfortunately these details were not being read so the display incorrectly showed the details of the current owning basket. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15531 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks like it has been caused by commit 9501ac2feffa8aca965fd24156560870df4065c3 Bug 15531: Add support for standing orders Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 [Bug 15531] Add support for standing orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org