[Bug 19255] New: Correct explanation about list types on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Bug ID: 19255 Summary: Correct explanation about list types on shelves.pl in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl
From Jonathan on bug 18980: On the staff interface: """ Private list: Is managed by you and can be seen only by you. Public list: Can be seen by everybody, but managed only by you. """
Should not we update it? If a list is private but shared, the description is wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 [Bug 18980] Add an explanation when Anyone permission has no actual effect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correct explanation about |Correct explanation about |list types on shelves.pl in |list categories on |staff |shelves.pl in staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66853&action=edit Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- I was wondering if you could fix some other grammar while you are at it too. "Once the list is saved it will accessible" it will BE accessible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66868&action=edit Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66853|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66889&action=edit Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66868|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66890&action=edit Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Thanks for the followup addressing comment #2, Marcel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Bug 19255 depends on bug 18980, which changed state. Bug 18980 Summary: Add an explanation when Anyone permission has no actual effect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66889|0 |1 is obsolete| | Attachment #66890|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67759&action=edit Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67760&action=edit Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67761&action=edit Bug 19255: QA Followup - Fix tabs for spaces Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org