[Bug 22945] New: Markup error in OPAC search results around lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Bug ID: 22945 Summary: Markup error in OPAC search results around lists display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- There are a couple of markup errors in opac-results.tt which trigger HTML validation errors: - "Text not allowed in element ul in this context." - "Stray end tag span." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89934&action=edit Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89934|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 90634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90634&action=edit Eliminates both error messages. Looks good, thanks Owen. Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90634|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90698&action=edit Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org