https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16750 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90580&action=edit Bug 23117: Shortcut additem.pl on nonexistent biblionumber To prevent additem.pl to crash when called with a nonexistent biblionumber we are here implementing the blocking_error.inc trick to display a friendly message instead. Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test plan: hit /cataloguing/additem.pl?biblionumber= /cataloguing/additem.pl?biblionumber=424242 You will get a friendly "Bibliographic record not found." message, instead of a 500 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90580|0 |1 is obsolete| | --- Comment #2 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 90618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90618&action=edit Bug 23117: Shortcut additem.pl on nonexistent biblionumber To prevent additem.pl to crash when called with a nonexistent biblionumber we are here implementing the blocking_error.inc trick to display a friendly message instead. Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test plan: hit /cataloguing/additem.pl?biblionumber= /cataloguing/additem.pl?biblionumber=424242 You will get a friendly "Bibliographic record not found." message, instead of a 500 Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90618|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90623&action=edit Bug 23117: Shortcut additem.pl on nonexistent biblionumber To prevent additem.pl to crash when called with a nonexistent biblionumber we are here implementing the blocking_error.inc trick to display a friendly message instead. Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test plan: hit /cataloguing/additem.pl?biblionumber= /cataloguing/additem.pl?biblionumber=424242 You will get a friendly "Bibliographic record not found." message, instead of a 500 Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.