[Bug 39053] New: Add page-section div to reports results pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Bug ID: 39053 Summary: Add page-section div to reports results pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 Many reports pages lack the <div class="page-section"> wrapper around the table of results. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177579&action=edit Bug 39053: Add page-section div to reports results pages This patch adds a "page-section" wrapping div around reports results pages where it is missing. Note: This patch contains indentation changes. To test, apply the patch and test the following reports, confirming that the results page looks correct: - Patrons with the most checkouts - Acquisitions statistics - Patrons with no checkouts - Patrons statistics - Most-circulated items - Catalog statistics - Average loan time - Circulation statistics - Lost items - Catalog by item types - Holds statistics Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177579|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 177658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177658&action=edit Bug 39053: Add page-section div to reports results pages This patch adds a "page-section" wrapping div around reports results pages where it is missing. Note: This patch contains indentation changes. To test, apply the patch and test the following reports, confirming that the results page looks correct: - Patrons with the most checkouts - Acquisitions statistics - Patrons with no checkouts - Patrons statistics - Most-circulated items - Catalog statistics - Average loan time - Circulation statistics - Lost items - Catalog by item types - Holds statistics Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes several report release notes| |result pages so that they | |have a "page-section" div - | |they now have a white | |background, instead of the | |light grey background. --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. The database strict mode needs to be turne doff for these reports to work: - Patrons with the most checkouts - Patrons with no checkouts 2. To turn off the database strict mode: - vi /etc/koha/sites/kohadev/koha-conf.xml - Search for strict - Change strict_sql_modes from 1 to 0: <strict_sql_modes>0</strict_sql_modes> - Restart everything: restart_all 3. Add some appropriate data so that the "Lost items" reports is generated: - Edit an item for a record so that it has a lost status of "Lost" - For the report options for Library: change to "All" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177658|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177943&action=edit Bug 39053: Add page-section div to reports results pages This patch adds a "page-section" wrapping div around reports results pages where it is missing. Note: This patch contains indentation changes. To test, apply the patch and test the following reports, confirming that the results page looks correct: - Patrons with the most checkouts - Acquisitions statistics - Patrons with no checkouts - Patrons statistics - Most-circulated items - Catalog statistics - Average loan time - Circulation statistics - Lost items - Catalog by item types - Holds statistics Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177943|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178084&action=edit Bug 39053: Add page-section div to reports results pages This patch adds a "page-section" wrapping div around reports results pages where it is missing. Note: This patch contains indentation changes. To test, apply the patch and test the following reports, confirming that the results page looks correct: - Patrons with the most checkouts - Acquisitions statistics - Patrons with no checkouts - Patrons statistics - Most-circulated items - Catalog statistics - Average loan time - Circulation statistics - Lost items - Catalog by item types - Holds statistics Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, this fails the QA check for me, can you please have a look? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt FAIL tt_valid lines 93, 272 FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt FAIL tt_valid lines 63, 65, 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could this be a non-issue? Joubu told that qa script still needs attention on that front.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure really, hence the question to have another look. All tidy related patches should be pushed now and I have made sure (hopefully) to have the newest versions. As Owen worked on the tidy, it might be easier for him to determine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #7)
Joubu told that qa script still needs attention on that front..
That was my assumption when submitting the patch: "Important: ignore tt_valid QA test failures for now" https://chat.koha-community.org/koha-community/pl/ihyw6dj7ptg9iczcbxa4pjesue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #9)
(In reply to Marcel de Rooy from comment #7)
Joubu told that qa script still needs attention on that front..
That was my assumption when submitting the patch: "Important: ignore tt_valid QA test failures for now" https://chat.koha-community.org/koha-community/pl/ihyw6dj7ptg9iczcbxa4pjesue
Ok, not a blocker then. Thanks for verifying :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to main |Pushed to stable --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. Changes to screenshots may be required, but these should (eventually) be picked up with the automated sceenshots. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org