[Bug 39038] New: Collapsing nonpatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Bug ID: 39038 Summary: Collapsing nonpatron Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Collapsing nonpatron |Collapsing | |nonpatron_guarantor field | |collapses guarantor field --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- When selecting 'Non-patron guarantor' in CollapsedFieldsPatronAddForm the guarantor form is collapsed too. This is because we are doing a grep for the string and one contains the other -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177532&action=edit Bug 39038: Grep for exacpt matches for collapsed fields This patch splits the preference into a list in TT and then uses grep to find exact matches for each field To test: 1 - Edit CollapsedFieldsPatronAddForm preference and check Non-patron guarantor and a few otehr fields, not Guarantor though 2 - Go to add a patron that can have a guarantor 3 - Note bot h guarantor fields are collapsed 4 - Apply patch, reload 5 - Note only expected fields are collapsed 6 - Confirm other fields continue to work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 177554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177554&action=edit Bug 39038: Grep for exact matches for collapsed fields This patch splits the CollapseFieldsPatronAddForm system preference into a list in the template and then uses grep to find exact matches for each field. Test plan: 1. Edit CollapseFieldsPatronAddForm system preference and check the Non-patron guarantor and a few other fields, but not Guarantor. 2. Go to add a patron that can have a guarantor. 3. Note both guarantor fields are collapsed. 4. Apply patch, reload/ 5. Note only expected fields are collapsed. 6. Confirm other fields continue to work as expected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #177532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the add patron release notes| |form when using the | |CollapseFieldsPatronAddForm | |system preference to | |collapse sections of the | |form. If the "Non-patron | |guarantor" option was | |selected it was also | |collapsing the "Patron | |guarantor" section. Summary|Collapsing |CollapseFieldsPatronAddForm |nonpatron_guarantor field |- Collapsing "Non-patron |collapses guarantor field |guarantor" section also | |collapses the "Patron | |guarantor" section --- Comment #4 from David Nind <david@davidnind.com> --- I edited the commit message to use the correct system preference name, and fixed some spelling mistakes 8-) I've also created bug 39047. If you select the "Patron messaging preferences" option for the CollapseFieldsPatronAddForm system preference, when adding or editing patrons the collapsed section displays a progress spinner and "Loading new messaging defaults". (This is not related to this bug, as it did this before this patch.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177554|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 178097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178097&action=edit Bug 39038: Grep for exact matches for collapsed fields This patch splits the CollapseFieldsPatronAddForm system preference into a list in the template and then uses grep to find exact matches for each field. Test plan: 1. Edit CollapseFieldsPatronAddForm system preference and check the Non-patron guarantor and a few other fields, but not Guarantor. 2. Go to add a patron that can have a guarantor. 3. Note both guarantor fields are collapsed. 4. Apply patch, reload/ 5. Note only expected fields are collapsed. 6. Confirm other fields continue to work as expected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178097|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178446&action=edit Bug 39038: Grep for exact matches for collapsed fields This patch splits the CollapseFieldsPatronAddForm system preference into a list in the template and then uses grep to find exact matches for each field. Test plan: 1. Edit CollapseFieldsPatronAddForm system preference and check the Non-patron guarantor and a few other fields, but not Guarantor. 2. Go to add a patron that can have a guarantor. 3. Note both guarantor fields are collapsed. 4. Apply patch, reload/ 5. Note only expected fields are collapsed. 6. Confirm other fields continue to work as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39038 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org