[Bug 39858] New: Cannot save vendor if it has invoices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Bug ID: 39858 Summary: Cannot save vendor if it has invoices Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org I found while trying to add a contact to a vendor. Not sure if the invoices themselves are relevant. To reproduce: 1. Have a vendor with some invoice 2. Try adding a contact (I added a name and an email) 3. Hit 'Submit' => FAIL: You get a yellow error message about a problem saving. => FAIL: The logs say something like: ``` [2025/05/07 18:08:18] [ERROR] PUT /api/v1/acquisitions/vendors/2: unhandled exception (Koha::Exceptions::Object::PropertyNotFound)<<No property invoices_count for Koha::Acquisition::Bookseller>> ``` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |38010 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182038&action=edit Bug 39858: Fix saving vendors with invoices This patch makes the form remove the `invoices_count` attribute from the object before sending it to the API. To test: 1. Have a vendor with some invoice 2. Edit the vendor to add a contact (for example) 3. Click 'Submit' => FAIL: Error, cannot be saved 4. Apply this patch 5. Rebuild the Vue assets: $ ktd --shell k$ yarn js:build 6. Restart: k$ restart_all 7. Reload the browser page and edit the vendor 8. Click 'Submit' => SUCCESS: It saved 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182038|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 182039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182039&action=edit Bug 39858: Fix saving vendors with invoices This patch makes the form remove the `invoices_count` attribute from the object before sending it to the API. To test: 1. Have a vendor with some invoice 2. Edit the vendor to add a contact (for example) 3. Click 'Submit' => FAIL: Error, cannot be saved 4. Apply this patch 5. Rebuild the Vue assets: $ ktd --shell k$ yarn js:build 6. Restart: k$ restart_all 7. Reload the browser page and edit the vendor 8. Click 'Submit' => SUCCESS: It saved 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182039|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182073&action=edit Bug 39858: Fix saving vendors with invoices This patch makes the form remove the `invoices_count` attribute from the object before sending it to the API. To test: 1. Have a vendor with some invoice 2. Edit the vendor to add a contact (for example) 3. Click 'Submit' => FAIL: Error, cannot be saved 4. Apply this patch 5. Rebuild the Vue assets: $ ktd --shell k$ yarn js:build 6. Restart: k$ restart_all 7. Reload the browser page and edit the vendor 8. Click 'Submit' => SUCCESS: It saved 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38010 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org