https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190012&action=edit Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0 warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "datatables.net@^1.13.1". warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "jquery@^3.6.0". Test plan: yarn build should not show those 2 warnings after this patch is applied @RM: You will need to push yarn.lock as well -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- So this is not directly a problem since datatables and jquery are available as globals in compatible versions. On resolution, yarn just can't find them because they are not in package.json and not installed via that route yet. The patch would add them, but we would still continue using the static version in koha-tmpl/{intranet,opac}-tmpl/lib/. To make at least the datatables.net-vue use them, we would need to remove datatables.net and jquery from the externals field in rspack.config.js, but then they would get bundled inside the vue assets and that would essentially be duplication because they are already available as globals. The better solution would be to either copy the version from node_modules to the static lib dirs at build time or to make Asset.pm scan node_modules. Since we are essentially tracking the versions we use in package.json via this patch, just not copying it yet, it could still be a valid way to silence the warnings, but more work is needed here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190012|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190786&action=edit Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0 warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "datatables.net@^1.13.1". warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "jquery@^3.6.0". Test plan: yarn build should not show those 2 warnings after this patch is applied @RM: You will need to push yarn.lock as well Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190786|0 |1 is obsolete| | --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 190829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190829&action=edit Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0 warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "datatables.net@^1.13.1". warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "jquery@^3.6.0". Test plan: yarn build should not show those 2 warnings after this patch is applied @RM: You will need to push yarn.lock as well Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I was trying to replicate but didn't get the warning. David had it and told me they had a node_modules dir still lying around in their koha code dir. So it's possible the warning only happens under that condition (and maybe with the right old libs in node_modules). I wonder if other people correlate the warning with a node_modules still there? Anyway, thanks Paul for the QA, I couldn't have tell if the patch would still make sense if the issue is old node_modules lying around. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 --- Comment #7 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.